Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cropImage upload through the preview is not working #181

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

Afonso-santos
Copy link
Contributor

@Afonso-santos Afonso-santos commented Jun 13, 2023

I was trying to resolve the issue, but the problem is the crop image is blocking the upload image. With a lot of search I dint't find nothing to solve the problem so i remove this features .

@netlify
Copy link

netlify bot commented Jun 13, 2023

Deploy Preview for coderdojobraga-web canceled.

Name Link
🔨 Latest commit 7015a67
🔍 Latest deploy log https://app.netlify.com/sites/coderdojobraga-web/deploys/6570827f163a0800082e5dec

@netlify
Copy link

netlify bot commented Jun 13, 2023

Deploy Preview for coderdojobraga-blog canceled.

Name Link
🔨 Latest commit 7015a67
🔍 Latest deploy log https://app.netlify.com/sites/coderdojobraga-blog/deploys/6570827f6727580008635162

@Afonso-santos Afonso-santos linked an issue Jun 13, 2023 that may be closed by this pull request
@netlify
Copy link

netlify bot commented Jun 13, 2023

Deploy Preview for coderdojobraga-app ready!

Name Link
🔨 Latest commit 7015a67
🔍 Latest deploy log https://app.netlify.com/sites/coderdojobraga-app/deploys/6570827f1f623a000841daa7
😎 Deploy Preview https://deploy-preview-181--coderdojobraga-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jun 13, 2023

Deploy Preview for coderdojobraga-maintenance canceled.

Name Link
🔨 Latest commit 7015a67
🔍 Latest deploy log https://app.netlify.com/sites/coderdojobraga-maintenance/deploys/6570827f049b8e00081c1882

@ruilopesm
Copy link
Member

We shouldn't remove this - it's such a nice feature.
If it isn't working, we have to fix it 👀

@MarioRodrigues10
Copy link
Member

We shouldn't remove this - it's such a nice feature. If it isn't working, we have to fix it eyes

I was with Afonso when he did this and we spent a whole afternoon looking for a solution to the problem, we found out that ImgCrop was returning null instead of an image, we didn't understand why we tried to look for a solution but we couldn't find any that works.
We also tried to update the version but we found out that wasn't the reason.
If you have any suggestions we'll appreciate it. 😄

@ruilopesm
Copy link
Member

Make sure the conflicts are solved 🙏🏼

apps/app/components/AppMenu/index.tsx Outdated Show resolved Hide resolved
apps/app/components/Register/index.tsx Outdated Show resolved Hide resolved
apps/app/pages/settings.tsx Outdated Show resolved Hide resolved
apps/app/pages/settings.tsx Outdated Show resolved Hide resolved
apps/app/components/Profile/index.tsx Outdated Show resolved Hide resolved
@MarioRodrigues10 MarioRodrigues10 changed the title Remove cropImage upload through the preview is not working Fix cropImage upload through the preview is not working Jun 25, 2023
Copy link
Member

@MarioRodrigues10 MarioRodrigues10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a problem in register, when i upload a picture , the picture preview disappears.
Here's an image that explains that:
image

@ruioliveira02
Copy link
Member

To fix the CI rebase with main

@ruilopesm ruilopesm changed the title Fix cropImage upload through the preview is not working fix: cropImage upload through the preview is not working Aug 20, 2023
@ruilopesm ruilopesm added the app App related contributions label Aug 20, 2023
@Afonso-santos
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app App related contributions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image upload through the preview is not working
4 participants