Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove: hall of fame #197

Merged
merged 3 commits into from
Sep 26, 2023
Merged

remove: hall of fame #197

merged 3 commits into from
Sep 26, 2023

Conversation

Afonso-santos
Copy link
Contributor

No description provided.

@Afonso-santos Afonso-santos self-assigned this Sep 23, 2023
@netlify
Copy link

netlify bot commented Sep 23, 2023 •
edited
Loading

✅ Deploy Preview for coderdojobraga-blog canceled.

Name Link
🔨 Latest commit 21844d5
🔍 Latest deploy log https://app.netlify.com/sites/coderdojobraga-blog/deploys/651181397ab71b000850f884

@reviewpad reviewpad bot added the web Web related contributions label Sep 23, 2023
@reviewpad
Copy link

reviewpad bot commented Sep 23, 2023

AI-Generated Summary: This pull request removes the "Hall of Fame" feature from the codebase. Specifically, it deletes the hall_of_fame.json data file and the hall-of-fame.tsx page, resulting in the removal of 104 lines of code. It also comments out the "Hall of Fame" menu entry from the landing/Header configuration, thus hiding this feature from the UI.

@netlify
Copy link

netlify bot commented Sep 23, 2023 •
edited
Loading

✅ Deploy Preview for coderdojobraga-web ready!

Name Link
🔨 Latest commit 21844d5
🔍 Latest deploy log https://app.netlify.com/sites/coderdojobraga-web/deploys/651181396b39eb0008ebf58f
😎 Deploy Preview https://deploy-preview-197--coderdojobraga-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 23, 2023 •
edited
Loading

✅ Deploy Preview for coderdojobraga-app canceled.

Name Link
🔨 Latest commit 21844d5
🔍 Latest deploy log https://app.netlify.com/sites/coderdojobraga-app/deploys/651181393f1bf30008a33942

@netlify
Copy link

netlify bot commented Sep 23, 2023 •
edited
Loading

✅ Deploy Preview for coderdojobraga-maintenance canceled.

Name Link
🔨 Latest commit 21844d5
🔍 Latest deploy log https://app.netlify.com/sites/coderdojobraga-maintenance/deploys/6511813957fd0a0008d62039

@ruilopesm ruilopesm changed the title Delete Hall of fame remove: hall of fame Sep 24, 2023
ruilopesm
ruilopesm reviewed Sep 24, 2023
View reviewed changes
Copy link
Member

@ruilopesm ruilopesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solve the conflicts with main 🙏🏼

ruilopesm
ruilopesm reviewed Sep 24, 2023
View reviewed changes
Copy link
Member

@ruilopesm ruilopesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also remove the JSON file 💡

@ruilopesm
Copy link
Member

We should also remove the JSON file 💡

@Afonso-santos

@Afonso-santos Afonso-santos merged commit ea19a3e into main Sep 26, 2023
19 checks passed
@Afonso-santos Afonso-santos deleted the as/remove_hall_of_fame branch September 26, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruilopesm ruilopesm ruilopesm approved these changes

@danielsp45 danielsp45 Awaiting requested review from danielsp45

Assignees

@Afonso-santos Afonso-santos

Labels
web Web related contributions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Afonso-santos @ruilopesm