New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: nomenclature in register page #212

Merged

Afonso-santos merged 13 commits into main from as/add_nomenclature

Dec 4, 2023

Contributor

Afonso-santos commented Nov 23, 2023

I worked in this solution to resolve the problem we have with the nomenclatures.
If you have any suggestions for the descriptions let me know.


          fix nomenclature in register pag

3572dbd

Afonso-santos requested review from joaodiaslobo, danielsp45, ruilopesm, diogogmatos and pedrofp4444

November 23, 2023 09:32

Afonso-santos self-assigned this

netlify bot commented Nov 23, 2023 •

edited

Loading

✅ Deploy Preview for coderdojobraga-maintenance canceled.

Name	Link
🔨 Latest commit	`1e915f7`
🔍 Latest deploy log	https://app.netlify.com/sites/coderdojobraga-maintenance/deploys/656c722d7af2410008cc02a9

reviewpad bot added the app label

netlify bot commented Nov 23, 2023 •

edited

Loading

✅ Deploy Preview for coderdojobraga-blog canceled.

Name	Link
🔨 Latest commit	`1e915f7`
🔍 Latest deploy log	https://app.netlify.com/sites/coderdojobraga-blog/deploys/656c722d4447790008706f52

netlify bot commented Nov 23, 2023 •

edited

Loading

✅ Deploy Preview for coderdojobraga-web canceled.

Name	Link
🔨 Latest commit	`1e915f7`
🔍 Latest deploy log	https://app.netlify.com/sites/coderdojobraga-web/deploys/656c722dc8064e0008237334

netlify bot commented Nov 23, 2023 •

edited

Loading

✅ Deploy Preview for coderdojobraga-app ready!

Name	Link
🔨 Latest commit	`1e915f7`
🔍 Latest deploy log	https://app.netlify.com/sites/coderdojobraga-app/deploys/656c722dd81cbf000896d906
😎 Deploy Preview	https://deploy-preview-212--coderdojobraga-app.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

reviewpad bot requested review from afonsopimenta, EnzoVieira and ruioliveira02

November 23, 2023 09:34

reviewpad bot commented Nov 23, 2023

AI-Generated Summary: This pull request primarily renames and revises the Signup component in the web application. The changes include renaming index.js to index.tsx to reflect the usage of TypeScript, correction in the naming conventions throughout the code, and enhancement of the user interface for device role selection with special tool-tips detailing each device role.

Additions to the form include:

TypeScript annotations,
'Space' component for improved layout,
Descriptive text labels on the device role radio buttons (for guardians and mentors),
and a tooltip for ninjas, who can't self-register.

There are also modifications to the error handling, particularly for the requirement to agree to terms and conditions, and for the handling of cases where an email is already registered.

This patch thus both addresses nomenclature issues and enhances user experience through GUI improvements and better error handling.

Afonso-santos added 3 commits

November 23, 2023 10:39


          correct some request

6f1b9ef


          correct some request


          correct React Hook

686cf53

Contributor Author

Afonso-santos commented Nov 23, 2023

Esclarecimento da nomenclatura de Guardião e Mentor

danielsp45 requested changes

View reviewed changes

apps/app/components/Signup/index.tsx Outdated

+                          <Radio value="mentor" className="mb-2">
+                            Mentor
+                            <label id="mentor-description" className="ml-5 text-gray-500">
+                              Voluntário pela iniciativa.

Member

danielsp45 Nov 23, 2023

Muda para "Voluntário na organização"

apps/app/components/Signup/index.tsx Outdated

+                          <Radio value="guardian" className="mb-2">
+                            Guardião
+                            <label id="mentor-description" className="ml-2 text-gray-500">
+                              Responsável da criança.

Member

danielsp45 Nov 23, 2023

Muda para "Responsável pela criança"

Afonso-santos added 2 commits

November 23, 2023 22:11


          Request changes

1ceaa82


          Correct some react hook

208d594

Afonso-santos requested a review from danielsp45

November 23, 2023 23:09

danielsp45 previously approved these changes

View reviewed changes

nelsonmestevao reviewed

View reviewed changes

apps/app/components/Signup/index.tsx Outdated

+                          <Radio value="guardian" className="mb-2">
+                            Guardião
+                            <label id="mentor-description" className="ml-2 text-gray-500">
+                              Responsável pela criança.

Member

nelsonmestevao Nov 25, 2023

Suggested change

      
                            Responsável pela criança.
          
                            Tutor legal da criança.


          Request changes

6ada13e

Afonso-santos dismissed danielsp45’s stale review via

6ada13e

November 27, 2023 21:35

reviewpad bot added the web label


          Run formater

f00d823


          Correct some warming

dd1ee52

Afonso-santos requested review from nelsonmestevao and danielsp45

November 27, 2023 21:53


          Fix:email verification

c8fd4d4

danielsp45 requested changes

View reviewed changes

apps/app/components/Signup/index.tsx Outdated

Comment on lines 78 to 79

		Guardião
		<label id="mentor-description" className="ml-2 text-gray-500">

Member

danielsp45 Nov 29, 2023

Suggested change

      
                          Guardião
          
                          <label id="mentor-description" className="ml-2 text-gray-500">
          
                          <span className="inline-block w-20">Guardião</span>
          
                          <label id="mentor-description" className="text-gray-500">

apps/app/components/Signup/index.tsx Outdated

Comment on lines 85 to 86

		Mentor
		<label id="mentor-description" className="ml-6 text-gray-500">

Member

danielsp45 Nov 29, 2023

Suggested change

      
                          Mentor
          
                          <label id="mentor-description" className="ml-6 text-gray-500">
          
                          <span className="inline-block w-20">Mentor</span>
          
                          <label id="mentor-description" className="text-gray-500">

apps/app/components/Signup/index.tsx Outdated

+                            </label>
+                          </Radio>
+                          <Tooltip
+                            className={styles.option}

Member

danielsp45 Nov 29, 2023

Suggested change

className={styles.option}

apps/app/components/Signup/index.tsx Outdated

Comment on lines 95 to 96

		Ninja
		<label id="mentor-description" className="ml-8 text-gray-500">

Member

danielsp45 Nov 29, 2023

Suggested change

      
                            Ninja
          
                            <label id="mentor-description" className="ml-8 text-gray-500">
          
                            <span className="inline-block w-20">Ninja</span>
          
                            <label id="mentor-description" className="text-gray-500">


          Request changes and run format

e7d74a7

reviewpad bot added the blog label


          Run format and lint

e28b5af

Afonso-santos requested a review from danielsp45

December 3, 2023 11:08


          correct some misunderstandings

1e915f7

danielsp45 approved these changes

View reviewed changes

Afonso-santos merged commit f30950c into main

19 checks passed

Afonso-santos deleted the as/add_nomenclature branch

December 4, 2023 08:51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

danielsp45 danielsp45 approved these changes

joaodiaslobo Awaiting requested review from joaodiaslobo

ruilopesm Awaiting requested review from ruilopesm

diogogmatos Awaiting requested review from diogogmatos

pedrofp4444 Awaiting requested review from pedrofp4444

afonsopimenta Awaiting requested review from afonsopimenta

EnzoVieira Awaiting requested review from EnzoVieira

ruioliveira02 Awaiting requested review from ruioliveira02

nelsonmestevao Awaiting requested review from nelsonmestevao

Labels