-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove webConsolePlugin from ToolchainClusterConfig (phase 2) #438
Conversation
Pendo has been decommisioned, we don't need this plugin anymore Signed-off-by: Xavier Coulon <[email protected]>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. But let's make sure we update stage and prod configuration first to make sure those fields are not present in actual ToolchainConfig resources anymore before merging this PR.
And also please make sure there are host and member CRDs changes without any go.mod replace in them (and they are green) before merging this PR. |
already done in https://github.com/codeready-toolchain/sandbox-sre/pull/1885 :) |
I'm a bit confused by your request, could you elaborate on what needs to be verified exactly? |
never mind, I found the explanations in codeready-toolchain/host-operator#1068 (comment) so here are the changes you requested (hopefully): |
Pendo has been decommisioned, we don't need this plugin anymore
Signed-off-by: Xavier Coulon [email protected]