Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove webConsolePlugin from ToolchainClusterConfig (phase 2) #438

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

xcoulon
Copy link
Contributor

@xcoulon xcoulon commented Jul 26, 2024

Pendo has been decommisioned, we don't need this plugin anymore

Signed-off-by: Xavier Coulon [email protected]

Pendo has been decommisioned, we don't need this plugin anymore

Signed-off-by: Xavier Coulon <[email protected]>
Copy link

sonarcloud bot commented Jul 26, 2024

Copy link
Contributor

@alexeykazakov alexeykazakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. But let's make sure we update stage and prod configuration first to make sure those fields are not present in actual ToolchainConfig resources anymore before merging this PR.

@alexeykazakov
Copy link
Contributor

And also please make sure there are host and member CRDs changes without any go.mod replace in them (and they are green) before merging this PR.

@xcoulon
Copy link
Contributor Author

xcoulon commented Jul 29, 2024

Looks good. But let's make sure we update stage and prod configuration first to make sure those fields are not present in actual ToolchainConfig resources anymore before merging this PR.

already done in https://github.com/codeready-toolchain/sandbox-sre/pull/1885 :)

@xcoulon
Copy link
Contributor Author

xcoulon commented Jul 29, 2024

And also please make sure there are host and member CRDs changes without any go.mod replace in them (and they are green) before merging this PR.

I'm a bit confused by your request, could you elaborate on what needs to be verified exactly?
Are you suggesting that we should have a set of PRs which only contain the removal in the CRDs, without any change in the Go types?

@xcoulon
Copy link
Contributor Author

xcoulon commented Jul 29, 2024

And also please make sure there are host and member CRDs changes without any go.mod replace in them (and they are green) before merging this PR.

I'm a bit confused by your request, could you elaborate on what needs to be verified exactly? Are you suggesting that we should have a set of PRs which only contain the removal in the CRDs, without any change in the Go types?

never mind, I found the explanations in codeready-toolchain/host-operator#1068 (comment)

so here are the changes you requested (hopefully):
codeready-toolchain/host-operator#1069
codeready-toolchain/member-operator#589
codeready-toolchain/toolchain-e2e#1021

@xcoulon xcoulon changed the title remove webConsolePlugin from ToolchainClusterConfig remove webConsolePlugin from ToolchainClusterConfig (phase 2) Jul 30, 2024
@xcoulon xcoulon merged commit ed4387f into codeready-toolchain:master Aug 1, 2024
3 checks passed
@xcoulon xcoulon deleted the remove_pendo_api branch August 1, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants