Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add new field for TemplateObjects in TierTemplate CRD to support go template syntax #1080

Merged
merged 20 commits into from
Sep 12, 2024

Conversation

mfrancisc
Copy link
Contributor

Copy link

sonarcloud bot commented Sep 10, 2024

Copy link

openshift-ci bot commented Sep 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, MatousJobanek, mfrancisc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MatousJobanek,alexeykazakov,mfrancisc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mfrancisc mfrancisc merged commit af41b2c into codeready-toolchain:master Sep 12, 2024
11 of 12 checks passed
@mfrancisc mfrancisc deleted the templateObjects branch September 12, 2024 11:31
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.09%. Comparing base (3b10773) to head (b139c5a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1080      +/-   ##
==========================================
+ Coverage   85.07%   85.09%   +0.01%     
==========================================
  Files          55       55              
  Lines        5038     5038              
==========================================
+ Hits         4286     4287       +1     
+ Misses        581      580       -1     
  Partials      171      171              

see 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants