Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the latest toolchain-common version #1082

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

metlos
Copy link
Contributor

@metlos metlos commented Sep 6, 2024

This updates to the latest toolchain-common version. It should have been part of #1058 that I mistakenly merged with toolchain-common reference that is a commit behind.

Copy link

sonarcloud bot commented Sep 6, 2024

Copy link
Contributor

@ranakan19 ranakan19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good,
maybe link the e2e PR updating the toolchain-common in the description too?

@openshift-ci openshift-ci bot added the approved label Sep 6, 2024
Copy link

openshift-ci bot commented Sep 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, metlos, mfrancisc, ranakan19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alexeykazakov,mfrancisc,ranakan19]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metlos metlos merged commit 724001f into codeready-toolchain:master Sep 9, 2024
12 of 13 checks passed
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.09%. Comparing base (2266710) to head (83e0de9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1082      +/-   ##
==========================================
+ Coverage   85.07%   85.09%   +0.01%     
==========================================
  Files          55       55              
  Lines        5038     5038              
==========================================
+ Hits         4286     4287       +1     
+ Misses        581      580       -1     
  Partials      171      171              

see 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants