-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add banneduser middleware #1083
add banneduser middleware #1083
Conversation
Signed-off-by: Francesco Ilario <[email protected]>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I made it a bit simpler in #1084
but feel free to merge it and I'll take care of the conflicts in my PR
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexeykazakov, filariow, MatousJobanek, mfrancisc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ok, I was faster, so let's close this PR as the reg-service should have "full view" permissions for the whole Toolchain API group |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1083 +/- ##
=======================================
Coverage 85.07% 85.07%
=======================================
Files 55 55
Lines 5038 5038
=======================================
Hits 4286 4286
Misses 581 581
Partials 171 171 |
Supersedes #1079
Linked to codeready-toolchain/registration-service#455 and codeready-toolchain/toolchain-e2e#1045