Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add banneduser middleware #1083

Conversation

filariow
Copy link
Contributor

@filariow filariow commented Sep 9, 2024

Signed-off-by: Francesco Ilario <[email protected]>
Copy link

sonarcloud bot commented Sep 9, 2024

@openshift-ci openshift-ci bot added the approved label Sep 9, 2024
Copy link
Contributor

@MatousJobanek MatousJobanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I made it a bit simpler in #1084
but feel free to merge it and I'll take care of the conflicts in my PR

Copy link

openshift-ci bot commented Sep 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, filariow, MatousJobanek, mfrancisc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MatousJobanek,alexeykazakov,mfrancisc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MatousJobanek
Copy link
Contributor

Ok, I was faster, so let's close this PR as the reg-service should have "full view" permissions for the whole Toolchain API group

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.07%. Comparing base (7e3ae3b) to head (2764c5a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1083   +/-   ##
=======================================
  Coverage   85.07%   85.07%           
=======================================
  Files          55       55           
  Lines        5038     5038           
=======================================
  Hits         4286     4286           
  Misses        581      581           
  Partials      171      171           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants