Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format CRD description in CSV #1099

Conversation

MatousJobanek
Copy link
Contributor

to match the format after running make bundle

Copy link

sonarcloud bot commented Oct 10, 2024

Copy link
Contributor

@mfrancisc mfrancisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

Copy link
Contributor

@metlos metlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there something to fix in the make generate target in the api so that we don't get this diff in the future?

Copy link

openshift-ci bot commented Oct 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MatousJobanek, metlos, mfrancisc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MatousJobanek,mfrancisc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metlos
Copy link
Contributor

metlos commented Oct 10, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 10, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 27a18d0 into codeready-toolchain:master Oct 10, 2024
12 checks passed
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.10%. Comparing base (917d10b) to head (7c01129).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1099   +/-   ##
=======================================
  Coverage   85.10%   85.10%           
=======================================
  Files          55       55           
  Lines        5041     5041           
=======================================
  Hits         4290     4290           
  Misses        580      580           
  Partials      171      171           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants