Make NSTemplateTier generator generic #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatousJobanek
requested review from
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19,
sbryzak and
mfrancisc
as code owners
MatousJobanek
commented
Apr 3, 2024
Comment on lines
+35
to
+36
| //go:embed testdata/nstemplatetiers* | ||
| var testTemplateFiles embed.FS |
There was a problem hiding this comment.
this is just a copy-paste of what was in host-operator: https://github.com/codeready-toolchain/host-operator/tree/master/test/templates/nstemplatetiers
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #381 +/- ##
==========================================
+ Coverage 75.75% 77.66% +1.91%
==========================================
Files 45 46 +1
Lines 1728 1952 +224
==========================================
+ Hits 1309 1516 +207
- Misses 367 376 +9
- Partials 52 60 +8
|
alexeykazakov
approved these changes
Apr 3, 2024
mfrancisc
approved these changes
Apr 4, 2024
| for _, tierTmpl := range tierTmpls.tierTemplates { | ||
| log.Info("creating TierTemplate", "namespace", tierTmpl.Namespace, "name", tierTmpl.Name) | ||
| // using the "standard" client since we don't need to support updates on such resources, they should be immutable | ||
| if _, err := t.ensureObject(tierTmpl, false); err != nil { |
There was a problem hiding this comment.
the second parameter wasn't immediately clear to me, but I like the new ensureObject function.
|
fbm3307
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the logic of nstemplatetier_generator.go from host-operator to toolchain-common and make it generic so it can be used by a ksctl command for generating NSTemplateTier & TierTemplate manifests locally in a GitOps repository.
There is almost no change in the logic of the generator, it should work in the same way as it was before, just with the difference that it doesn't load templates from the assets, but takes them from the map passed as a parameter.
KUBESAW-59
related PR in host-operator repo codeready-toolchain/host-operator#1006