Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade uuid to v5 #388

Closed
wants to merge 1 commit into from
Closed

upgrade uuid to v5 #388

wants to merge 1 commit into from

Conversation

ranakan19
Copy link
Contributor

@ranakan19 ranakan19 mentioned this pull request Apr 22, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Apr 22, 2024 •
edited
Loading

Codecov Report

Merging #388 (43d1a9e) into master (e6d41ea) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #388   +/-   ##
=======================================
  Coverage   77.98%   77.98%           
=======================================
  Files          47       47           
  Lines        1958     1958           
=======================================
  Hits         1527     1527           
  Misses        373      373           
  Partials       58       58
Files Coverage Δ
pkg/notification/notification_builder.go 87.80% <ø> (ø)

fbm3307
fbm3307 reviewed Apr 23, 2024
View reviewed changes
go.sum
@@ -218,6 +218,8 @@ github.com/goccy/go-json v0.10.2/go.mod h1:6MelG93GURQebXPDq3khkgXZkazVtN9CRI+MG
github.com/godbus/dbus/v5 v5.0.4/go.mod h1:xhWf0FNVPg57R7Z0UbKHbJfkEywrmjJnf7w5xrFpKfA=
github.com/gofrs/uuid v3.3.0+incompatible h1:8K4tyRfvU1CYPgJsveYFQMhpFd/wXNM7iK6rR7UHz84=
github.com/gofrs/uuid v3.3.0+incompatible/go.mod h1:b2aQJv3Z4Fp6yNu3cdSllBxTCLRxnplIgP/c0N/04lM=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The V3 version of gfrs should be removed i think ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try to run go mod tidy

@rajivnathan
Copy link
Contributor

Is it worth switching to github.com/google/uuid to be consistent with kubesaw/ksctl#34 ?

@ranakan19
Copy link
Contributor Author

Is it worth switching to github.com/google/uuid to be consistent with kubesaw/ksctl#34 ?

when i created this PR, the intention was to use gofrs/uuid in ksctl as well. But then, I talked to @alexeykazakov and we chose to with google instead - so here is the new PR which replaces gofrs with google uuid - #395.
I will mark this PR as closed now.

@ranakan19 ranakan19 closed this May 2, 2024
@ranakan19 ranakan19 reopened this May 2, 2024
@ranakan19
Copy link
Contributor Author

Closing this PR in favor of #395

@ranakan19 ranakan19 closed this May 2, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
5.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatousJobanek MatousJobanek MatousJobanek approved these changes

@fbm3307 fbm3307 fbm3307 left review comments

@xcoulon xcoulon Awaiting requested review from xcoulon xcoulon is a code owner

@alexeykazakov alexeykazakov Awaiting requested review from alexeykazakov alexeykazakov is a code owner

@rajivnathan rajivnathan Awaiting requested review from rajivnathan rajivnathan is a code owner

@sbryzak sbryzak Awaiting requested review from sbryzak

@mfrancisc mfrancisc Awaiting requested review from mfrancisc mfrancisc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ranakan19 @rajivnathan @MatousJobanek @fbm3307