Do not use the now removed CapacityThresholds in the tests and the utility methods. #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onfig-capacity-thresholds
This can now be merged to master.
metlos
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19,
sbryzak and
mfrancisc
as code owners
|
rajivnathan
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a copy of #379 to get us past the stuck CI jobs.
This updates the tests to not use the
CapacityThresholdsin theToolchainConfig, because those fields are being removed in the associatedapiPR (codeready-toolchain/api#411).Additionally, test utility methods for the
CapacityThresholdsare also removed.See https://issues.redhat.com/browse/KUBESAW-36.
Associated PRs:
- host-operator: codeready-toolchain/host-operator#1000
- toolchain-e2e: codeready-toolchain/toolchain-e2e#935
- api: codeready-toolchain/api#411