Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KUBESAW-16: Label the token secrets #396

Merged
merged 9 commits into from
May 14, 2024

Conversation

metlos
Copy link
Contributor

@metlos metlos commented May 2, 2024

Make sure the secret containing the creds for clients connecting between clusters is labeled as belonging to its ToolchainCluster resource.

This will be used in the future to base the creation of the ToolchainClusters on the existence of such secrets.

Associated PRs:

clusters is labeled as belonging to its ToolchainCluster resource.

This will be used in the future to base the creation of the ToolchainClusters
on the existence of such secrets.
Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 57.89474% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 77.87%. Comparing base (0cabe6c) to head (3027359).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #396      +/-   ##
==========================================
- Coverage   78.06%   77.87%   -0.20%     
==========================================
  Files          47       47              
  Lines        1965     1984      +19     
==========================================
+ Hits         1534     1545      +11     
- Misses        373      378       +5     
- Partials       58       61       +3     
Files Coverage Δ
...rs/toolchaincluster/toolchaincluster_controller.go 61.53% <57.89%> (-2.10%) ⬇️

Copy link
Contributor

@MatousJobanek MatousJobanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but let's also cover the error case when the update would fail.
Are you going to create also a e2e test for it?

Copy link
Contributor

@mfrancisc mfrancisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Job 👍

one minor question - should we add a test case for "secret not found" ?

@metlos
Copy link
Contributor Author

metlos commented May 9, 2024

one minor question - should we add a test case for "secret not found" ?

good point 👍🏼 it's added.

Copy link
Contributor

@mfrancisc mfrancisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for addressing my comments!

Copy link

sonarcloud bot commented May 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
6.7% Duplication on New Code

See analysis details on SonarCloud

@metlos metlos merged commit 1ceadb6 into codeready-toolchain:master May 14, 2024
8 of 9 checks passed
@metlos metlos deleted the label-token-secrets branch May 14, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants