Remove the migration step to add labels to creds secret for ToolchainClusters. #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToolchainClusters.
metlos
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19,
sbryzak and
mfrancisc
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #400 +/- ##
==========================================
+ Coverage 77.79% 77.98% +0.19%
==========================================
Files 47 47
Lines 1977 1958 -19
==========================================
- Hits 1538 1527 -11
+ Misses 378 373 -5
+ Partials 61 58 -3
|
|
fully agree with you 👍 |
This was referenced Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$TITLE.With all the clusters already updated, we can remove this migration step. IMHO, we should KEEP the test for the presence of the labels in
toolchain-e2e(https://github.com/codeready-toolchain/toolchain-e2e/blob/master/test/e2e/toolchaincluster_test.go#L43) until we actually flip the logic and create theToolchainClusters based on the secrets.