Remove the migration step to kubeconfig #426
Merged
+124
−423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for the legacy fields in ToolchainCluster.
metlos
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19,
sbryzak and
mfrancisc
as code owners
This was referenced Aug 26, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #426 +/- ##
==========================================
- Coverage 78.57% 77.35% -1.23%
==========================================
Files 49 49
Lines 2054 2009 -45
==========================================
- Hits 1614 1554 -60
- Misses 379 401 +22
+ Partials 61 54 -7
|
mfrancisc
reviewed
Aug 27, 2024
controllers/toolchaincluster/toolchaincluster_controller_test.go
Outdated
Show resolved
Hide resolved
MatousJobanek
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
Looks good from my side, but please address @mfrancisc's comments
fbm3307
approved these changes
Aug 29, 2024
(some of) the future surprises.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the migration step to kubeconfig and update the tests to not test for the legacy fields in ToolchainCluster.
This a follow-up of #412 that updates the testsuite to not rely on the legacy fields that defined the connection settings for the clusters.
This is safe to do, because all of our clusters have already been upgraded and have the kubeconfigs generated in the connection secrets.
Related PRs: