Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct site when loading settings #342

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vsalvino
Copy link
Contributor

@vsalvino vsalvino commented Aug 2, 2020

Location pages currently use the default site for getting GoogleApiSettings. This should instead use the page's site.

WIP - Mailchimp integration also needs refactored.

@vsalvino vsalvino added the PR: Work in Progress Not ready for merge or review yet label Aug 2, 2020
@vsalvino
Copy link
Contributor Author

vsalvino commented Aug 2, 2020

Tests are currently failing because:

  • When a page is initially created, it does not belong to a site.
  • It is then added to a page tree, which belongs to a site.
  • So any activity that happens on page save() cannot rely on a site (therefore site settings) being present.

Not sure how to best handle this, as the Location pages specifically need to perform geocoding on save. Perhaps there is a wagtail hook which will help (i.e. we could geocode after added to page tree versus after saving)

@vsalvino vsalvino changed the base branch from master to dev January 11, 2021 19:31
@vsalvino vsalvino added this to the 0.22.0 milestone Aug 4, 2021
@vsalvino vsalvino modified the milestones: 0.22.0, 0.23.0 Sep 9, 2021
@vsalvino vsalvino modified the milestones: 0.23.0, 0.24.0 May 11, 2022
@vsalvino vsalvino removed this from the 0.24.0 milestone Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Multisite 🏨 PR: Work in Progress Not ready for merge or review yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant