Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements.txt to avoid version conflicts #15

Merged

Conversation

ashwinvis
Copy link
Contributor

@ashwinvis ashwinvis commented Sep 2, 2024

Pinning a minimum version of sphinx-rtd-theme >= 2.0.0 mitigate from getting old version of sphinx-rtd-theme.

readthedocs/sphinx_rtd_theme#1571 (comment)

This only happens if I use uv's resolver. With pip it computes versions a bit more conservatively. Anyways, it is good to have.

Pinning a minimum version of `sphinx-rtd-theme >= 2.0.0` mitigate from getting old version of sphinx-rtd-theme.

readthedocs/sphinx_rtd_theme#1571 (comment)
@ashwinvis
Copy link
Contributor Author

ashwinvis commented Sep 2, 2024

For some context, while building a lesson, I was unable to build locally for a while due to a mysterious error:

Reason: UndefinedError("'style' is undefined")

Turns out sphinx v8.x dropped and the latest sphinx-rtd-theme was pinned <8 which became a strong constraint and I ended up getting an ancient version of sphinx-rtd-theme 0.5.

@bast
Copy link
Member

bast commented Sep 3, 2024

Thanks! This is a much nicer fix than me restricting sphinx to below 8.0.

@bast bast merged commit dad96ad into coderefinery:main Sep 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants