Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(clippy): apply clippy suggestions #31

Closed
wants to merge 24 commits into from
Closed

refactor(clippy): apply clippy suggestions #31

wants to merge 24 commits into from

Conversation

kinggoesgaming
Copy link

  • refactor(clippy): clippy::needless_return
  • refactor(clippy): clippy::cmp_owned
  • refactor(clippy): clippy::needless_question_mark
  • refactor(clippy): clippy::clone_on_copy
  • refactor(clippy): clippy::needless_borrows_for_generic_args
  • refactor(clippy): clippy::ptr_arg
  • refactor(clippy): clippy::match_single_binding
  • refactor(clippy): clippy::unnecessary_cast
  • refactor(clippy): clippy::cast_abs_to_unsigned
  • refactor(clippy): clippy::ineffective_open_options
  • refactor(clippy): clippy::needless_borrow
  • refactor(clippy): clippy::while_let_on_iterator
  • refactor(clippy): clippy::single_match
  • refactor(clippy): clippy::map_clone
  • refactor(clippy): clippy::to_string_in_format_args
  • refactor(clippy): clippy::needless_else
  • refactor(clippy): clippy::enum_variant_names
  • refactor(clippy): clippy::single_char_pattern
  • refactor(clippy): clippy::collapsible_if
  • refactor(clippy): unused
  • refactor(clippy): unused_mut
  • refactor(clippy): dead_code
  • refactor(clippy): unused_variables
  • refactor(clippy): clippy::comparison_chain

closes #27

@kinggoesgaming kinggoesgaming marked this pull request as draft February 20, 2024 20:17
@kinggoesgaming
refactor(clippy): clippy::needless_return
0e7e412 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
refactor(clippy): clippy::cmp_owned
8202362 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
refactor(clippy): clippy::needless_question_mark
96f51ca 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
refactor(clippy): clippy::clone_on_copy
451378d 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
refactor(clippy): clippy::needless_borrows_for_generic_args
5af1b87 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
refactor(clippy): clippy::ptr_arg
a45ccd1 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
refactor(clippy): clippy::match_single_binding
81c4870 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
refactor(clippy): clippy::unnecessary_cast
56a2435 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
refactor(clippy): clippy::cast_abs_to_unsigned
52057db 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
refactor(clippy): clippy::ineffective_open_options
376d911 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
refactor(clippy): clippy::needless_borrow
45bf71e 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
refactor(clippy): clippy::while_let_on_iterator
057349b 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
refactor(clippy): clippy::single_match
babb84e 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
refactor(clippy): clippy::map_clone
1b72dd0 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
refactor(clippy): clippy::to_string_in_format_args
5d794ad 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
refactor(clippy): clippy::needless_else
677c661 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
refactor(clippy): clippy::enum_variant_names
97926f1 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
refactor(clippy): clippy::single_char_pattern
656cd08 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
refactor(clippy): clippy::collapsible_if
805d2e1 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
refactor(clippy): unused
21acd1b 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
refactor(clippy): unused_mut
4ea0653 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
refactor(clippy): dead_code
2379a49 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
refactor(clippy): unused_variables
fbdf0d2 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
refactor(clippy): clippy::comparison_chain
771a1cb 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming kinggoesgaming force-pushed the 27-cleanup-code-with-suggestions-from-clippy branch from 1097566 to 771a1cb Compare February 20, 2024 20:41
@kinggoesgaming kinggoesgaming marked this pull request as ready for review February 20, 2024 20:41
@kinggoesgaming kinggoesgaming mentioned this pull request Feb 21, 2024
Open
@kinggoesgaming
Copy link
Author

This is ready to be merged

@fcoury fcoury closed this Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleanup code with suggestions from clippy
2 participants
@kinggoesgaming @fcoury