Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(logger): new logger with env_logger #35

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

feat(logger): new logger with env_logger #35

wants to merge 8 commits into from

Conversation

kinggoesgaming
Copy link

  • chore(deps): add log
  • chore(deps): add env_logger
  • chore(deps): add tempfile
  • feat(logger): initialize env_logger
  • refactor(logger): use log macros
  • refactor(logger): create the file correctly
  • refactor(logger): remove previous Logger impl

closes #32
closes #34

@kinggoesgaming
chore(deps): add log
ed1d3db 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
chore(deps): add env_logger
bb0861a 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
chore(deps): add tempfile
7e5233d 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
feat(logger): initialize env_logger
49e460a 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
refactor(logger): use log macros
a53c318 
Also removes the `log` macro that was defined.

Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
refactor(logger): create the file correctly
2443a7b 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
refactor(logger): remove previous Logger impl
466f9b2 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
Copy link
Author

will open this again... it seems I have changes that bled over from #31

@kinggoesgaming kinggoesgaming deleted the 32-use-log-and-env-logger-crates-for-logging branch February 21, 2024 13:00
@kinggoesgaming kinggoesgaming restored the 32-use-log-and-env-logger-crates-for-logging branch February 22, 2024 07:07
@kinggoesgaming
Copy link
Author

So checking into it.. I believe this is correct

@kinggoesgaming
refactor(logger): init logger before anything else
4660640 
Also print the location of the log file.

Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming kinggoesgaming changed the title feat(logger): new logger with env_loggger feat(logger): new logger with env_logger Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use tempfile to create the log file Use log and env_logger crates for logging
1 participant
@kinggoesgaming