Security issue #177
Merged
Security issue #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rupeshiya
force-pushed
the
security_issue
branch
2 times, most recently
from
aa9a4b7
to
51faa6e
Compare
Rupeshiya
force-pushed
the
security_issue
branch
from
51faa6e
to
ab37557
Compare
|
Did you run test cases after making security changes. Looks good to go overall :) |
| const WINDOW_LOG_INTERVAL_IN_HOURS = 1 | ||
|
|
||
| module.exports = { | ||
| customRateLimiter: (req, res, next) => { |
There was a problem hiding this comment.
Please add a testcase for this.
There was a problem hiding this comment.
Rate limiter is working tried to send more than 100 requests then it's sending this responses:
There was a problem hiding this comment.
Increased no of requests in testing env to 500 and in development or prod 200 no of requests
|
Rate limiter: Other test cases |
|
Passing all the test cases except #137 issue |
vaibhavdaren
approved these changes
Aug 24, 2020
Rupeshiya
added a commit
to Rupeshiya/social-platform-donut-backend
that referenced
this pull request
Aug 25, 2020
* update code * initial mechanism for user tracking initial mechanism for user tracking Security issue (codeuino#177) * update code * fix security flaws * fixed test cases minor fixes
Rupeshiya
added a commit
to Rupeshiya/social-platform-donut-backend
that referenced
this pull request
Aug 26, 2020
* update code * fixed failing test cases and missing test cases User activity tracker using redis (codeuino#174) * update code * initial mechanism for user tracking initial mechanism for user tracking Security issue (codeuino#177) * update code * fix security flaws * fixed test cases hot fix add docs for contributors
vaibhavdaren
added a commit
that referenced
this pull request
Sep 13, 2020
* added update restrictions, techStacks in project and orgId to a user * added edit restriction mechanism * intial deactivation mechanism * intial logging mechanism and deactive account * issue fix * fixing org creation issue * Fixes issues in testing (#160) * fix failing test file user.test.js * fixes EADDRINUSE while testing * fixes issues in prposal route * fixed issues in org route and added new tests * Moving Google Analytics requests to backend (#154) * Moving Google Analytics requetss to backend * Requested Changes * Minor changes * Adding code to prevent attacks (#153) * modified user's api (#168) * modified user's api * login options during login * Changes for reactions (#166) * Revert "Adding code to prevent attacks (#153)" (#170) This reverts commit 57a0cf9. * Fixed and written all the missing test cases (#172) * update code * fixed failing test cases and missing test cases * User activity tracker using redis (#174) * update code * initial mechanism for user tracking initial mechanism for user tracking * Security issue (#177) * update code * fix security flaws * fixed test cases * minor fixes (#178) * add docs for new contributors (#181) Co-authored-by: Devesh Verma <[email protected]> Co-authored-by: Kumar Saurabh Raj <[email protected]> Co-authored-by: Asel Peiris <[email protected]> Co-authored-by: pranjals149 <[email protected]> Co-authored-by: Vaibhav D. Aren <[email protected]>
vaibhavdaren
added a commit
that referenced
this pull request
Sep 13, 2020
* added update restrictions, techStacks in project and orgId to a user * added edit restriction mechanism * intial deactivation mechanism * intial logging mechanism and deactive account * issue fix * fixing org creation issue * Fixes issues in testing (#160) * fix failing test file user.test.js * fixes EADDRINUSE while testing * fixes issues in prposal route * fixed issues in org route and added new tests * Moving Google Analytics requests to backend (#154) * Moving Google Analytics requetss to backend * Requested Changes * Minor changes * Adding code to prevent attacks (#153) * modified user's api (#168) * modified user's api * login options during login * Changes for reactions (#166) * Revert "Adding code to prevent attacks (#153)" (#170) This reverts commit 57a0cf9. * Fixed and written all the missing test cases (#172) * update code * fixed failing test cases and missing test cases * User activity tracker using redis (#174) * update code * initial mechanism for user tracking initial mechanism for user tracking * Security issue (#177) * update code * fix security flaws * fixed test cases * minor fixes (#178) * add docs for new contributors (#181) * frontend sync master gsoc (#169) (#191) * added update restrictions, techStacks in project and orgId to a user * added edit restriction mechanism * intial deactivation mechanism * intial logging mechanism and deactive account * issue fix * fixing org creation issue * Fixes issues in testing (#160) * fix failing test file user.test.js * fixes EADDRINUSE while testing * fixes issues in prposal route * fixed issues in org route and added new tests * Moving Google Analytics requests to backend (#154) * Moving Google Analytics requetss to backend * Requested Changes * Minor changes * Adding code to prevent attacks (#153) * modified user's api (#168) * modified user's api * login options during login * Changes for reactions (#166) Co-authored-by: Rupeshiya <[email protected]> Co-authored-by: Devesh Verma <[email protected]> Co-authored-by: Kumar Saurabh Raj <[email protected]> Co-authored-by: Asel Peiris <[email protected]> Co-authored-by: pranjals149 <[email protected]> Co-authored-by: Devesh Verma <[email protected]> Co-authored-by: Vaibhav D. Aren <[email protected]> Co-authored-by: Kumar Saurabh Raj <[email protected]> Co-authored-by: Asel Peiris <[email protected]> Co-authored-by: pranjals149 <[email protected]> Co-authored-by: Rupeshiya <[email protected]> Co-authored-by: Devesh Verma <[email protected]> Co-authored-by: Kumar Saurabh Raj <[email protected]> Co-authored-by: Asel Peiris <[email protected]> Co-authored-by: pranjals149 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Pull Request template
about: Describe the PR.
title: ''
labels: ''
assignees: ''
Problem
Github Issue Number: #176
Fix security flaws
Solution of problem
Fixed:
Type of Change
[ ] Bug fix
[ ] New Feature
[ ] Development of UI/UX prototypes
[✓] Small refactor
[ ] Change in Documentation
Checklist
[✓] My code follows the same style as the codebase
[ ] My Code change requires a change in documentation
[ ] I have updated the Readme accordingly
[✓] I made PR against development branch
[✓] I have run the test cases locally and it's passing.
[ ] I have squashed my commits