backspace event tests fixed

codex-team · Aug 3, 2023 · ed0bf3b · ed0bf3b
1 parent 51654e2
commit ed0bf3b
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 11 deletions.
diff --git a/src/components/modules/blockEvents.ts b/src/components/modules/blockEvents.ts
@@ -454,10 +454,12 @@ export default class BlockEvents extends Module {
     BlockManager
       .mergeBlocks(targetBlock, blockToMerge)
       .then(() => {
-        /** Restore caret position after merge */
-        Caret.restoreCaret(targetBlock.pluginsContent as HTMLElement);
-        targetBlock.pluginsContent.normalize();
-        Toolbar.close();
+        window.requestAnimationFrame(() => {
+          /** Restore caret position after merge */
+          Caret.restoreCaret(targetBlock.pluginsContent as HTMLElement);
+          targetBlock.pluginsContent.normalize();
+          Toolbar.close();
+        });
       });
   }
 

diff --git a/src/components/modules/caret.ts b/src/components/modules/caret.ts
@@ -503,13 +503,10 @@ export default class Caret extends Module {
 
     sel.expandToTag(shadowCaret as HTMLElement);
 
-    setTimeout(() => {
-      const newRange = document.createRange();
+    const newRange = document.createRange();
 
-      newRange.selectNode(shadowCaret);
-      newRange.extractContents();
-    // eslint-disable-next-line @typescript-eslint/no-magic-numbers
-    }, 50);
+    newRange.selectNode(shadowCaret);
+    newRange.extractContents();
   }
 
   /**

diff --git a/test/cypress/tests/modules/BlockEvents/Backspace.cy.ts b/test/cypress/tests/modules/BlockEvents/Backspace.cy.ts
@@ -252,7 +252,8 @@ describe('Backspace keydown', function () {
       .last()
       .click()
       .type('{home}') // move caret to the beginning
-      .type('{backspace}');
+      .type('{backspace}')
+      .wait(100);
 
     /**
      * Current Block has been removed