-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui) : the block can be drag n drop #2285
Open
robonetphy
wants to merge
89
commits into
next
Choose a base branch
from
feat/dragndrop
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+829
−57
Open
Changes from 65 commits
Commits
Show all changes
89 commits
Select commit
Hold shift + click to select a range
f17b567
drag and drop nodes by handle
apresmoi 3b07911
fix linting issues
apresmoi 3d33b0c
fix lag in settingsToggler button after move
apresmoi 85ce277
fix naming in css
apresmoi 0c948ed
removing commented lines and moving return to if block
apresmoi 686ab6d
fix drop indicator classes cleaning out
apresmoi dfecf05
fix: removing JSON pattern
apresmoi 0857055
fix: handling dropping block without reference
apresmoi 28b6dc7
requested changes
apresmoi 2a7c1ad
fix linting issues
apresmoi 3207ec5
fix: reorder of lines
apresmoi ecaeba2
fix: conflicts with next branch
apresmoi 4d4718f
fix: restoring file to original state
apresmoi 776cb21
feat: adding processBlockDrop function impl
apresmoi df88f0d
Merge branch 'next' into feature/handler-drag-and-drop-838
apresmoi 8df628a
Merge remote-tracking branch 'origin/next' into feature/handler-drag-…
apresmoi cff8039
fix: rolling back css changes for drag&drop blocks feature
apresmoi 30441e7
feat: adding custom image when dragging block
apresmoi 9ba3363
fix: linting changes
apresmoi 25517ed
feat: proposal for drag and drop selected range
apresmoi 1cc6908
Merge branch 'next' into feature/handler-drag-and-drop-838
apresmoi be29a63
Merge branch 'next' into feature/handler-drag-and-drop-838
apresmoi 706c5ef
fix: flickering when dragging on top of caret
apresmoi 8835210
Merge branch 'next' into feat/dragndrop
robonetphy 508f7dd
content highlighting added in block settinga
robonetphy b5181f2
unused class removed from the PR
robonetphy 2fefd72
add the comments from the mutable listeners
robonetphy 9b6b517
remove the repetitive code
robonetphy a47584b
comments added
robonetphy 6c770ba
remove unused binding
robonetphy d29dfbd
remove repetitive code
robonetphy 49fe61c
event before clear section added
robonetphy 92fe458
drop target added
robonetphy f14394d
updates the events
robonetphy 3bbc9c2
remove unsed events
robonetphy a5c4c11
remove unused events
robonetphy 7d362cc
dragenter callback addedd
robonetphy f1cb715
comments added
robonetphy 4c5a199
update the enum for drop zone position
robonetphy 96deca8
comments added
robonetphy 445eaf3
cleardropTargets function added
robonetphy 722eb8e
unsed logic removed
robonetphy b7add56
dragImage creation and removal functionality added
robonetphy 2368264
unused code removed
robonetphy aa3dcd2
drop logic updated
robonetphy 2167b91
Caret added with drag and drop
robonetphy fa33f11
update the Inline tool close
robonetphy 23b7fd6
add the isDragStart getter
robonetphy b560b26
Merge branch 'next' into feat/dragndrop
robonetphy 0a4d53b
comments added
robonetphy 2f43494
updated the logic
robonetphy 10375f9
changes added
robonetphy 856475f
lint removed
robonetphy 17d2503
Merge branch 'next' into feat/dragndrop
robonetphy 55e31c0
fix dragndrop will toolbox open
robonetphy a210e6f
Merge branch 'next' into feat/dragndrop
robonetphy 0c8bb9d
update the problem with chrome and safari
robonetphy 77a37cc
Update index.ts
robonetphy 37b9c48
cypress-file-upload added
robonetphy fedab19
drag and drop test case initialized
robonetphy 1e8f689
test case for file drop added
robonetphy 0e599f0
dragover style testcases added
robonetphy 92845e7
scrolling feature while dragging added
robonetphy 890d636
drag and drop single test case added
robonetphy 0aeb6d6
multple element drag block added
robonetphy 501f8a2
remove the block selection filter
robonetphy 8399d54
improvements to logic
robonetphy d7c0cf8
undefined => false
robonetphy 62d0789
lint removed
robonetphy 5683a68
test cases modified
robonetphy 8ce1a26
testcase updated
robonetphy 960242f
file drop testcase added
robonetphy 643eb2e
the command added
robonetphy e5eec78
remove the cypress-file-upload
robonetphy 9e832b6
remove the lints
robonetphy 728c1ca
removed the lint
robonetphy 1e2fd9e
Merge branch 'next' into feat/dragndrop
ilyamore88 c16c561
refactor: rename spec file to support latest version of Cypress
ilyamore88 c901965
update dropTarget => dropZonePostion
robonetphy 5664950
create image logic updated
robonetphy a53484f
Merge branch 'next' into feat/dragndrop
robonetphy 09bbb9f
Update src/components/modules/dragNDrop.ts
robonetphy 28203e5
Merge branch 'next' into feat/dragndrop
robonetphy 2de7c7d
Merge branch 'next' into feat/dragndrop
robonetphy cc875f9
test case updated
robonetphy 13d92ca
Merge branch 'next' into feat/dragndrop
robonetphy 9f81269
get block by child element added
robonetphy 4f95a4e
the drop block at start added
robonetphy 8d6acaf
test case for the dropping of image added
robonetphy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks unintuitive for me, could it be
false
here instead ofundefined
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done