fix(renderer): handle empty array as data.blocks #2454
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if we pass
[]
as initial data or viablocks.render()
editor will contain no-blocks at all. It will break the UX sinceredactorClicked
will throw error:editor.js/src/components/modules/ui.ts
Lines 726 to 727 in f8e9414
Actually
.getBlockByIndex()
could returnundefined
(if we pass an unexisting index) — so I've addedundefined
as the return type. But in case of getting the last block by-1
it always should return a Block since it is expected that we always have at least one Block. So I've added overload for that case instead of checking onundefined
inredactorClicked
Resolves #2084