Swallow getLayoutMap() error #2790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damacisaac
requested review from
neSpecc,
gohabereg,
TatianaFomina and
ilyamore88
as code owners
|
@neSpecc @gohabereg @TatianaFomina @ilyamore88, anyone available for a review? I've had to fork the repo in the meantime |
|
@damacisaac thanks, I'll check it soon |
damacisaac
force-pushed
the
angus/upstream-fix
branch
2 times, most recently
from
c577744
to
fdf09c0
Compare
damacisaac
force-pushed
the
angus/upstream-fix
branch
from
fdf09c0
to
e963880
Compare
|
fixed the linting errors. should be good now |
|
@neSpecc could you trigger another run? |
|
Looks like a flakey attempt @neSpecc |
|
@TatianaFomina are you perhaps able to get this in? Sorry to push, just that we've had to implement some unsightly workarounds to get past this issue for the moment. |
neSpecc
approved these changes
Sep 13, 2024
|
Appreciate at it @neSpecc ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fail gracefully when
getLayoutMap()throws due to being run in an insecure context. We will fallback to the givenfallbackif this happens.This fixes #2789