Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: return fields updatedAt and createdAt with note #262

Merged
merged 3 commits into from
Jul 3, 2024
Merged

feat: return fields updatedAt and createdAt with note #262

merged 3 commits into from
Jul 3, 2024

Conversation

kloV148
Copy link
Contributor

@kloV148 kloV148 commented Jul 2, 2024

To display some fields in note settings we need to know, when was note updated

Whats done:

  • Added fields createdAt and updatedAt to note schema

Result: We get fields createdAt and updatedAt in response with note

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 86.21% (🎯 80%)
⬆️ +0.01%		 7667 / 8893
🟢 Statements 86.21% (🎯 80%)
⬆️ +0.01%		 7667 / 8893
🔴 Functions 79.53% (🎯 80%)
🟰 ±0%		 241 / 303
🟢 Branches 86% (🎯 80%)
🟰 ±0%		 387 / 450
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/presentation/http/schema/Note.ts 100% 100% 100% 100%
Generated in workflow #758

neSpecc
neSpecc reviewed Jul 2, 2024
View reviewed changes
Copy link
Member

@neSpecc neSpecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cover this field by tests, pls

@kloV148 kloV148 merged commit 157992d into main Jul 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neSpecc neSpecc neSpecc approved these changes

@elizachi elizachi elizachi approved these changes

@e11sy e11sy e11sy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kloV148 @neSpecc @elizachi @e11sy