Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added conflicting claims section on accept claims page #337

Closed
wants to merge 0 commits into from

Conversation

prathambatra
Copy link
Contributor

Signed-off-by: prathambatra [email protected]

@boss-contributions-bot
Copy link

Thanks @prathambatra, for opening the pull request! 🙌

One of our mentors will review the pull request soon. ✅

Star ⭐ this project and tweet 🐦 about your contributions.

@prathambatra
Copy link
Contributor Author

Screenshot from 2020-05-20 00-09-30
Screenshot from 2020-05-20 00-09-38
Screenshot from 2020-05-20 00-11-24
Screenshot from 2020-05-20 00-11-29
ezgif com-video-to-gif

@prathambatra
Copy link
Contributor Author

fixes #260

@YashKumarVerma
Copy link
Contributor

\hereisnaman \championswimmer please review.

image

@prathambatra
Copy link
Contributor Author

thanks @YashKumarVerma

@thenamankumar
Copy link
Contributor

@prathambatra can you fix the css. I see that is is problem with padding. Also please bring the Conflicting claims section below the update claim form. The form should go where the claim section is right now.

Or otherwise create a separate sidebar, but lets handle that in separate issue and bounty.

@prathambatra
Copy link
Contributor Author

@prathambatra can you fix the css. I see that is is problem with padding. Also please bring the Conflicting claims section below the update claim form. The form should go where the claim section is right now.

Or otherwise create a separate sidebar, but lets handle that in separate issue and bounty.

ok. so you mean I should replace places of update claim form and conflicted claims. right?

@thenamankumar
Copy link
Contributor

@prathambatra can you fix the css. I see that is is problem with padding. Also please bring the Conflicting claims section below the update claim form. The form should go where the claim section is right now.
Or otherwise create a separate sidebar, but lets handle that in separate issue and bounty.

ok. so you mean I should replace places of update claim form and conflicted claims. right?

Yes and fix the padding and other styles for claim section.

@prathambatra
Copy link
Contributor Author

@prathambatra can you fix the css. I see that is is problem with padding. Also please bring the Conflicting claims section below the update claim form. The form should go where the claim section is right now.
Or otherwise create a separate sidebar, but lets handle that in separate issue and bounty.

ok. so you mean I should replace places of update claim form and conflicted claims. right?

Yes and fix the padding and other styles for claim section.

Yeah sure

@prathambatra
Copy link
Contributor Author

Screenshot from 2020-05-22 15-58-56
@hereisnaman

@prathambatra
Copy link
Contributor Author

Is this fine? should I commit it?

@thenamankumar
Copy link
Contributor

Is this fine? should I commit it?

Can you not see there is padding issue in the conflict item header. Does a good UI element has such basic issues?

@prathambatra
Copy link
Contributor Author

Screenshot from 2020-05-22 20-19-22
Fixed padding in card header. Replaced the position of conflicting claims and form.

@prathambatra
Copy link
Contributor Author

please see #357

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants