-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[astro-purgecss] Handle custom 404 page #817
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b6eb919 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Jaanilj
commented
Dec 26, 2024
Jaanilj
commented
Dec 26, 2024
mhdcodes
approved these changes
Dec 28, 2024
mhdcodes
reviewed
Dec 28, 2024
mhdcodes
added
astro-purgecss
Issues related to astro-purgecss package
enhancement
New feature or request
labels
Dec 29, 2024
mhdcodes
changed the title
feat: add handling for custom 404 page in Astro integration
[astro-purgecss] Handle custom 404 pages
Dec 29, 2024
Jaanilj
force-pushed
the
handle-custom-404-page
branch
from
December 29, 2024 13:00
50bcbff
to
893e0fb
Compare
mhdcodes
previously approved these changes
Dec 29, 2024
mhdcodes
changed the title
[astro-purgecss] Handle custom 404 pages
[astro-purgecss] Handle custom 404 page
Dec 29, 2024
… and correct comment typo in generateFileHash function
…in build output paths, ensuring proper file generation at root level
Jaanilj
force-pushed
the
handle-custom-404-page
branch
from
December 29, 2024 13:49
893e0fb
to
cf092f1
Compare
@Jaanilj Thanks for taking the time to send this fix. If this is final, I’ll go ahead and merge it. |
mhdcodes
approved these changes
Dec 30, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds special handling for the
404
custom error page in Astro integration, ensuring proper file path generation based on Astro's documentation standards.Changes
404/
pathname to generate404.html
at the root levelTesting
404.astro
page in thesrc/pages/
folderChecklist