Fixed fail positive json detection (#210)

coduo · Sep 27, 2020 · b8ddc75 · b8ddc75
1 parent aaa3363
commit b8ddc75
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/src/Matcher/Pattern/Assert/Json.php b/src/Matcher/Pattern/Assert/Json.php
@@ -16,7 +16,13 @@ public static function isValid($value) : bool
             return false;
         }
 
-        if (null === \json_decode($value) && JSON_ERROR_NONE !== \json_last_error()) {
+        $result = \json_decode($value);
+
+        if (\is_float($result) && \is_infinite($result)) {
+            return false;
+        }
+
+        if (null === $result && JSON_ERROR_NONE !== \json_last_error()) {
             return false;
         }
 

diff --git a/tests/Matcher/JsonMatcherTest.php b/tests/Matcher/JsonMatcherTest.php
@@ -244,7 +244,11 @@ public static function positiveMatches()
             [
                 '[{"name": "Norbert"},{"name":"Michał"},{"name":"Bob"},{"name":"Martin"}]',
                 '"@[email protected]({\"name\": \"@string@\"})"'
-            ]
+            ],
+            [
+                '{"something": "5e61188283825"}',
+                '{"something": "@string@"}',
+            ],
         ];
     }