Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds necessary resources for cognoma to send emails and write to s3. #8

Merged
merged 7 commits into from
Oct 9, 2017

Conversation

kurtwheeler
Copy link
Member

Addresses issues #5, #6, #7. Creates a new IAM user for cognoma servers, grants access to write S3, grants everyone access to read from those S3 buckets, and grants the user the power to send emails.

@dcgoss dcgoss changed the title Adds neccessary resources for cognoma to send emails and write to s3. Adds necessary resources for cognoma to send emails and write to s3. Jul 7, 2017
Copy link
Member

@dcgoss dcgoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything server side is working. Still cannot access a file link, such as https://cognoma-files.s3.amazonaws.com/media/notebooks/classifier_5.ipynb

@kurtwheeler
Copy link
Member Author

@dcgoss and I discovered that somehow the URL got mixed up and it is in fact working with this configuration.

Copy link
Member

@dhimmel dhimmel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

concept acknowledgement. I.e. "Agree with the idea and overall direction, but haven't reviewed the code changes or tested them."

@dcgoss
Copy link
Member

dcgoss commented Jul 12, 2017

LGTM 👍

@dhimmel dhimmel merged commit eea0dd9 into cognoma:master Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants