Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable log_telemetry_imported_packages #52

Merged
merged 4 commits into from
Jul 19, 2023
Merged

Temporarily disable log_telemetry_imported_packages #52

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b35cb58
Temporarily disable log_telemetry_imported_packages
jrbourbeau Jul 18, 2023
30cf145
Rerun CI
jrbourbeau Jul 18, 2023
57859c6
Rerun CI
jrbourbeau Jul 18, 2023
2846919
Rerun CI
jrbourbeau Jul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions dask_snowflake/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,17 @@ def read_snowflake(
arrow_options,
)

# Disable `log_imported_packages_in_telemetry` as a temporary workaround for
# https://github.com/snowflakedb/snowflake-connector-python/issues/1648.
# Also xref https://github.com/coiled/dask-snowflake/issues/51.
if connection_kwargs.get("log_imported_packages_in_telemetry"):
raise ValueError(
"Using `log_imported_packages_in_telemetry=True` when creating a "
"Snowflake connection is not currently supported."
)
else:
connection_kwargs["log_imported_packages_in_telemetry"] = False

# Some clusters will overwrite the `snowflake.partner` configuration value.
# We fetch snowflake batches on the cluster to ensure we capture the
# right partner application ID.
Expand Down