Added Regular Expression Checking #37 #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#37 This PR fixes issue |
Sam2004-2
added a commit
to Sam2004-2/MorningBot-Sam-Dev
that referenced
this pull request
Nov 17, 2023
Changes to how messages are checked. Uses regex instead of literal string matching to add more expressive config Co-authored-by: David <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Morning bot PR
What does it do?
This pull request introduces changes to the
on_messagefunction in the Morning Bot. It utilizes regular expressions to check for good morning phrases, providing a more flexible and accurate detection.Why is it needed?
The current implementation uses a predefined list for good morning phrases. By incorporating regular expressions, the bot can intelligently detect a wider range of morning greetings, making it more robust and adaptable to different languages and variations as well as leading to fewer erroneous reactions.
Is this change tracked by an issue?
Yes, #37
Acceptance Criteria