Add Solana Signing Support, Examples #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Heimdall Review Status
|
drohit-cb
reviewed
Sep 18, 2024
| return base58EncodedSignedTx, nil | ||
| } | ||
|
|
||
| func broadcastSolTransaction(ctx context.Context, signedTx string) (string, error) { |
There was a problem hiding this comment.
I really think we should not be duplicating the sign/broadcast for every variation.
There was a problem hiding this comment.
I agree. Let me see if we can incorporate this into the SDK to help standardize this functionality.
ProfMoo
commented
Sep 19, 2024
There was a problem hiding this comment.
This example was actually doing numerous thing besides just build-staking-operation. I've split them up into 3 examples.
ProfMoo
changed the title
|
@deangalvin-cb I've added a couple unit test suites for the |
deangalvin-cb
approved these changes
Sep 20, 2024
|
@ProfMoo Love this. Thanks! Would be nice to follow up on the NodeJS SDK as well and have the same pattern both places. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
This PR adds an abstraction around the SDK's signing support in order to support signing staking operations for ETH and SOL using the same interface. This PR relies heavily on Golang's stdlib
crypto/rand.Alongside these changes, I included numerous Solana stake examples to provide full examples of how to stake SOL.
Our current Solana staking endpoint can take significant periods of time to get data from the underlying Solana nodes, so I've added the ability to modify the timeout on the client.