Fix Quickstart Template #186
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed `await transfer.wait();` since it was failing. Works now.
🟡 Heimdall Review Status
|
jazz-cb
reviewed
Aug 29, 2024
| @@ -24,6 +24,4 @@ const transfer = await wallet.createTransfer({ | |||
| }); | |||
|
|
|||
| // Wait for the transfer to complete or fail on-chain. | |||
| await transfer.wait(); | |||
There was a problem hiding this comment.
@SeanMGonzalez we added wait() on transfer object in the 0.1.0 release.
docs - https://coinbase.github.io/coinbase-sdk-nodejs/classes/coinbase_transfer.Transfer.html#wait
Could you run npm install from the quickstart-template directory and retry? want to make sure it is not an issue with cached local modules from the previous version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
removed
await transfer.wait();since it was failing. Works now.Qualified Impact
The quickstart template was broken after installation and running
npm run start, this fixes it.