Updating readContract args to take in any for the value #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
John-peterson-coinbase
approved these changes
Oct 19, 2024
jazz-cb
approved these changes
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
The current Record<String, String> interface for args is too strict, as it's possible for some read functions to take in a nested type. We have a potential fix for
argsthat works with nested types but it needs more testing. This PR instead sets it toany, which is much more permissive. It still however gives proper type-inference and shows the type that will be returned when a match occurs.I changed from unknowns and never to be
anywhich is to be more permissive. Until we have rock solid type-inference, this feels more appropriate.Testing
as unknown as Record<String, String>which was the temporary fix.Qualified Impact