Skip to content

Commit

Permalink
pythongh-118413: Fix test_release_task_refs on free-threaded build
Browse files Browse the repository at this point in the history
The `time.sleep()` call should happen before the GC to give the worker
threads time to clean-up their remaining references to objs.
Additionally, use `support.gc_collect()` instead of `gc.collect()`
just in case the extra GC calls matter.
  • Loading branch information
colesbury committed May 1, 2024
1 parent c408c36 commit 737b78b
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions Lib/test/_test_multiprocessing.py
Original file line number Diff line number Diff line change
Expand Up @@ -2804,7 +2804,6 @@ def test_map_no_failfast(self):
# check that we indeed waited for all jobs
self.assertGreater(time.monotonic() - t_start, 0.9)

@support.requires_gil_enabled("gh-118413: test is flaky with GIL disabled")
def test_release_task_refs(self):
# Issue #29861: task arguments and results should not be kept
# alive after we are done with them.
Expand All @@ -2813,8 +2812,8 @@ def test_release_task_refs(self):
self.pool.map(identity, objs)

del objs
gc.collect() # For PyPy or other GCs.
time.sleep(DELTA) # let threaded cleanup code run
support.gc_collect() # For PyPy or other GCs.
self.assertEqual(set(wr() for wr in refs), {None})
# With a process pool, copies of the objects are returned, check
# they were released too.
Expand Down

0 comments on commit 737b78b

Please sign in to comment.