Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove carousel tile from the package core #485

Open
hvelarde opened this issue Feb 24, 2015 · 9 comments · May be fixed by #524
Open

Remove carousel tile from the package core #485

hvelarde opened this issue Feb 24, 2015 · 9 comments · May be fixed by #524
Assignees
@hvelarde
Labels
enhancement in progress
Milestone
1.0b1

Comments

@hvelarde
Copy link
Member

Lately we have had some discussions about many things on the carousel tile and some pull requests have been proposed to offer an alternative solution

There are many solutions for carousels and everybody seems to have their own opinion on which one is the best.

So… should we just spin off the code of the carousel tile out of the core of this package to make it easier to maintain and leave people to choose whatever JS plug-in they want to use?
@hvelarde hvelarde mentioned this issue Feb 24, 2015
Closed
@djowett
Copy link
Contributor

djowett commented Mar 5, 2015

I think yes... but smoothing the migration could do with some bright ideas

@rodfersou
Copy link
Member

I agree with the idea too

@fredvd
Copy link
Member

fredvd commented Apr 1, 2015

Can't disagree here, suggested it in #442 :-)

@espenmn
Copy link
Member

espenmn commented Apr 14, 2015

Yes.
I think: as little as possible in the core,

(and also, if it should be of any interest, I started work with tiles for collective.plonetruegallery https://pypi.python.org/pypi/collective.ptg.tile/0.1b1 (worked when I made it, but has never been used on any sites)

@hvelarde
Copy link
Member Author

@espenmn feel free to document that on the README file

@djowett
Copy link
Contributor

djowett commented Apr 14, 2015

Just to log (for those who don't already know) that https://github.com/collective/covertile.cycle2 is a new carousel tile based on the Cycle2 framework. It could do with some review & feedback from any interested party before it's first release

@hvelarde
Copy link
Member Author

@djowett we are going to start using it tomorrow; we will let you know.

@hvelarde hvelarde mentioned this issue Apr 21, 2015
Closed
5 tasks
@djowett djowett changed the title Should we remove carousel tile from the package core? Remove carousel tile from the package core May 22, 2015
@djowett djowett removed the question label May 22, 2015
@djowett
Copy link
Contributor

djowett commented May 22, 2015

Correct me if I'm wrong, but this is not question any more...

@hvelarde
Copy link
Member Author

no, I will open a branch later today to address this issue and will move the code of the Galleria carousel to the new package.

@hvelarde hvelarde added this to the 1.0b1 milestone May 27, 2015
@hvelarde hvelarde self-assigned this May 27, 2015
@hvelarde hvelarde linked a pull request May 27, 2015 that will close this issue
Open
@hvelarde hvelarde mentioned this issue May 29, 2015
Closed
@hvelarde hvelarde mentioned this issue Sep 23, 2015
Open
@idgserpro idgserpro mentioned this issue Sep 14, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hvelarde hvelarde

Labels
enhancement in progress
Projects
None yet
Milestone
1.0b1
Development

Successfully merging a pull request may close this issue.

Remove carousel tile for core collective/collective.cover
5 participants
@rodfersou @hvelarde @fredvd @espenmn @djowett