Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pyproject.toml #707

Merged
merged 14 commits into from
Sep 28, 2024

Conversation

niccokunzmann
Copy link
Member

@niccokunzmann niccokunzmann commented Sep 4, 2024

This works on #686 and #635

  • python -m build
  • plone developers email still in use for this?
  • setup.cfg
  • tox test dependencies
  • In the readme, link to these:
    • "CONTRIBUTING.rst",
    • "CHANGES.rst",
    • "LICENSE.rst"
  • from setup.py:
  • ruff in tox
  • version.py
  • document tox -e ruff Use code styler #672
  • replace __version__ by version.py

I would like to get this done before we release v6


📚 Documentation preview 📚: https://icalendar--707.org.readthedocs.build/

@niccokunzmann niccokunzmann marked this pull request as draft September 4, 2024 14:55
@coveralls
Copy link

coveralls commented Sep 4, 2024

Pull Request Test Coverage Report for Build 11052885905

Details

  • 3 of 6 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 97.386%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/icalendar/version.py 3 6 50.0%
Totals Coverage Status
Change from base Build 10688236243: -0.1%
Covered Lines: 3190
Relevant Lines: 3273

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10704214164

Details

  • 3 of 6 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 97.386%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/icalendar/version.py 3 6 50.0%
Totals Coverage Status
Change from base Build 10688236243: -0.1%
Covered Lines: 3190
Relevant Lines: 3273

💛 - Coveralls

setup.py Show resolved Hide resolved
@niccokunzmann niccokunzmann marked this pull request as ready for review September 25, 2024 14:00
@niccokunzmann
Copy link
Member Author

After merging this, I would create a new release.

@niccokunzmann
Copy link
Member Author

@jacadzaca @geier would you review?

@niccokunzmann
Copy link
Member Author

@jacadzaca Thanks!

@niccokunzmann niccokunzmann merged commit ca260c8 into collective:main Sep 28, 2024
17 checks passed
@niccokunzmann niccokunzmann deleted the issue-686-pyproject.toml branch September 28, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants