Don't use ActiveRecord::Base as parent class #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've been facing performance issues with our delayed jobs table. One of the initiatives we're experimenting on is using a separate database for delayed jobs. Rails supports multiple database connections since version 6.0 using `ActiveRecord::ConnectionHandling#connects_to`. However, since 6.1, Rails does not allow using `connects_to` in non abstract classes to avoid opening multiple connections to the database. The recommeneded way to do it is to create a new abstract class and have your models that need a different connection inherit from that new abstract class. Also, the current version of the delayed job active record backend does not support connection config. The quickest work around is to make Delayed::Backend::ActiveRecord::Job inherit from a new abstract class Delayed::Backend::ActiveRecord::Base that can be monkey patched with minimal impact.
|
@albus522 any chance this could get reviewed? |
|
It's probably the right path forward but it is a breaking change so it warrants a bit more consideration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been facing performance issues with our delayed jobs table. One of the initiatives we're experimenting on is using a separate database for delayed jobs. Rails supports multiple database connections since version 6.0 using
ActiveRecord::ConnectionHandling#connects_to.However, since 6.1, Rails does not allow using
connects_toin non abstract classes to avoid opening multiple connections to the database. The recommended way to do it is to create a new abstract class and have your models that need a different connection inherit from that new abstract class.Also, the current version of the delayed job active record backend does not support connection config. The quickest work around is to make
Delayed::Backend::ActiveRecord::Jobinherit from a new abstract classDelayed::Backend::ActiveRecord::Basethat can be monkey patched with minimal impact.