Make several additional columns NOT NULL #238
Open
+16
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdufresne
force-pushed
the
timestamps-not-null
branch
from
365ffc5
to
9f804b4
Compare
The following columns are always set by Delayed Jobs and therefore expected to have a value and so can safely be set to be NOT NULL. - run_at - queue - timestamps (created_at, updated_at) By enforcing these are NOT NULL at the database layer, it improves data integrity by hardening the schema constraints.
jdufresne
changed the title
jdufresne
force-pushed
the
timestamps-not-null
branch
from
9f804b4
to
f3f693f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following columns are always set by Delayed Jobs and therefore expected to have a value and so can safely be set to be NOT NULL.
By enforcing these are NOT NULL at the database layer, it improves data integrity by hardening the schema constraints.