Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally exclude queues by worker #74

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

adamonduty
Copy link

This is an another attempt at pull #28 with tests (credit to @arjes for tracking down the code change). It also should be compatible with current/previous versions of DJ by using respond_to?. Assuming this pull is acceptable, I'll submit another to DJ proper to add the cli options.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 1289acd on adamonduty:exclude_queues into * on collectiveidea:master*.

@derekrockwell
Copy link

👍

@derekrockwell
Copy link

I've created a fork for a purpose similar to this with the notable difference that the query is

ready_scope = ready_scope.where('queue NOT IN (?) OR queue IS NULL', Worker.except_queues)

In order to pick up nameless queue jobs which would be restricted from the not in query comparing to nil, but would still make sense in an 'except queue' workflow imo.

@adamonduty
Copy link
Author

@derekrockwell Looks good to me! I did the same and pushed the branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants