-
-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Enable all relevant *Ruff* checks. #1318
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add type annotations to unit tests.
KelSolaar
force-pushed
the
feature/checks
branch
from
December 22, 2024 04:52
dfc620a
to
f8a54c5
Compare
KelSolaar
force-pushed
the
feature/checks
branch
from
December 22, 2024 04:55
f8a54c5
to
58f96f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables all the (autocratically deemed) relevant Ruff checks. Typing annotations have been added to the unit tests, implying that all the codebase is now checked by Pyright. All fixes are enabled by default. I will apply the same config to all the other colour-science repositories.
Preflight
Code Style and Quality
colour
,colour.models
.Documentation