Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Enable all relevant *Ruff* checks. #1318

Merged
merged 42 commits into from
Dec 22, 2024
Merged

PR: Enable all relevant *Ruff* checks. #1318

merged 42 commits into from
Dec 22, 2024

Conversation

KelSolaar
Copy link
Member

@KelSolaar KelSolaar commented Dec 22, 2024

Summary

This PR enables all the (autocratically deemed) relevant Ruff checks. Typing annotations have been added to the unit tests, implying that all the codebase is now checked by Pyright. All fixes are enabled by default. I will apply the same config to all the other colour-science repositories.

Preflight

Code Style and Quality

  • Unit tests have been implemented and passed.
  • Pyright static checking has been run and passed.
  • Pre-commit hooks have been run and passed.
  • [N/A] New transformations have been added to the Automatic Colour Conversion Graph.
  • [N/A] New transformations have been exported to the relevant namespaces, e.g. colour, colour.models.

Documentation

  • [N/A] New features are documented along with examples if relevant.
  • The documentation is Sphinx and numpydoc compliant.

@KelSolaar KelSolaar merged commit 8080937 into develop Dec 22, 2024
29 checks passed
@KelSolaar KelSolaar deleted the feature/checks branch December 22, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant