PR: Implement support for "MacAdam Limits" computation.

[gutenzwerg]

I wrote a program to calculate MacAdam-Limits. I presume it is, what was wished in the issue
Implement support for "Optimal Colour Stimuli" computation. #364

Every single whavelenght shoud be accurate enough. If necessary, it is possible to modify the program to use different cmfs instead of only CIE-31 2° by default.

[KelSolaar]

Hi @gutenzwerg,

Thanks, this looks great, initial code perusal tells me that we could optimise some chunks and generalise a bit more but it looks like an awesome start! There are some code style and pedantry things to address. I should have some time in the coming days to look at that properly. Bear with me, I'm super busy!

Cheers,

Thomas

[gutenzwerg]

Dear Thomas,

thanks for Your quick and enjoyable reply. I apologise for my old-fashioned programming-style. It is one of my first projects after a break of about 10 years of programming. On github I am a total newbie. I did single tests with YAPF and flake8 and I got at least no error messages, but trying to commit I got two failure indications. At least I did the upload within the graphical surface of github. So I have rather to ask to bear with me.

Do not hurry to much, I am patient.

Best regards,
Christian Greim

[zachlewis]

I can't say anything about the validity of the content, but everything seems straightforward enough, and I don't see anything that jumps out as problematic.

[zachlewis]

Think I bit off a bit more than I could chew when I started this review with the time I had available... let me take a closer look at the wording / phrasing this evening.

[zachlewis]

Suggested change

	brightness = bright_opti_colour(width, wavelength, Y_illuminated)
	if brightness < target_bright:
	width += 1
	brightness = bright_opti_colour(width, wavelength, Y_illuminated)
	rough_optimum = optimum_colour(width, wavelength)
	brightness = np.sum(rough_optimum * Y_illuminated) / maximum_brightness
	brightness = bright_opti_colour(width, wavelength, Y_illuminated)
	if brightness < target_bright:
	width += 1
	rough_optimum = optimum_colour(width, wavelength)
	brightness = np.sum(rough_optimum * Y_illuminated) / maximum_brightness

Seems like we can get rid of a brightness computation

[gutenzwerg]

You are right. I tried it out, and it worked perfectly. Thank You again.

[gutenzwerg]

As far as I see. My function "macadam_limits" is not build in in the actual version. Am I right?
I need help in resolving the moand conflicts written below. It all relates to stuff of rights and features within comment-areas. I have no idea what to write in.
Can anyone help me to resolve the conflicts? Otherwise this feature can not be implemented.

[KelSolaar]

Hi @gutenzwerg,

Yes, I never had time finish looking at your PR! We should try to rebase it on top of develop. If you are fine with that, I can give it a stab and push back into your branch?

Cheers,

Thomas

[KelSolaar]

I created a rebased branch here as an example: https://github.com/colour-science/colour/tree/feature/macadam_limits

Looking at the code there are certainly quite a few things that would need to be addressed before we can merge it.

[gutenzwerg]

@KelSolaar,
thank You for Your quick response. I am not a native-speaker. I simpliy do not understand some terms in Your first post:

• PR
• rebase it on top of develop
• stab
• push back into your branch

In the link of Your second post You suggest only one change in one line - that's o.k. If You have other points of critique please tell me. For me the code works fine in the actual state and the great help of zachlewis.

I do not know what I should change in colour/init.py, colour/volume/init.py and colour/volume/macadam_limits.py to avoid the error-messages in "This branch has conflicts that must be resolved".

best regards,
Christian