Part of #3928 [Testing Examples] Add First Class Python Support #4166

himanshumahajan138 · 2024-12-19T18:32:04Z

Pull Request

Adds First Class Python Support [Testing Examples]
Part of #3928

Description

Testing Examples for Python 1-test-suite, 2-test-deps, 3-integration-suite Examples

Related Issues

Link to related issue First Class Python Support (4000USD Bounty) #3928.

Checklist

1-test-suite
2-test-deps
3-integration-suite
Updated Documentation

Status

WIP & Require Review!!!

lihaoyi · 2024-12-23T01:22:18Z

CC @jodersky to take a look

…ahajan138/mill into issue-3928-testing

himanshumahajan138 · 2024-12-24T17:22:49Z

{@lihaoyi & @jodersky} Sir It's Done and Ready for final Review...

There is no Requirement for deep review coz its almost same as scalalib and other testing Examples still i would say let's Review and Finalize this PR...

himanshumahajan138 · 2024-12-27T09:43:08Z

it's been 3 days since completion But no Review 🥺

jodersky · 2024-12-27T10:33:23Z

Hey Himanshu, I've been with family over the christmas holidays, and before then I was sick. So unfortunately I haven't really had much time to spend on mill. Note however that I haven't forgotten about this, and I appreciate your patience

…

On Fri, Dec 27, 2024, 10:43 Himanshu Mahajan ***@***.***> wrote: it's been 3 days since completion But no Review 🥺 — Reply to this email directly, view it on GitHub <#4166 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHV3JCKUBNROYOCAMKVVTD2HUOMFAVCNFSM6AAAAABT5SSYXWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRTGUYTKNJXGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

himanshumahajan138 · 2024-12-27T10:45:56Z

@jodersky No Worries, Sir we can wait till 2025 start, after New Year we can work on this....

BTW Happy New Year ✨

Thanks for Your Response 🤞

jodersky · 2025-01-02T09:32:18Z

Hey @himanshumahajan138 , happy new year! Just got back

himanshumahajan138 · 2025-01-03T10:46:20Z

@jodersky Sir i dont think this failing python testcase should fail in general what u say ?

[3980] X mill.testkit.UtestExampleTestSuite.exampleTest 71829ms 
[3980]   utest.AssertionError: assert(filteredOut.linesIterator.exists(globMatches(expectedLine, _)))
[3980]   filteredOut: String = Collecting mypy==1.13.0
[3980]     Using cached mypy-1.13.0-cp312-cp312-manylinux_2_17_x86_64.manylinux2014_x86_64.manylinux_2_28_x86_64.whl.metadata (2.1 kB)
[3980]   Collecting pex==2.24.1
[3980]     Using cached pex-2.24.1-py2.py3-none-any.whl.metadata (7.6 kB)
[3980]   Collecting typing-extensions>=4.6.0 (from mypy==1.13.0)
[3980]     Using cached typing_extensions-4.12.2-py3-none-any.whl.metadata (3.0 kB)
[3980]   Collecting mypy-extensions>=1.0.0 (from mypy==1.13.0)
[3980]     Using cached mypy_extensions-1.0.0-py3-none-any.whl.metadata (1.1 kB)
[3980]   Using cached mypy-1.13.0-cp312-cp312-manylinux_2_17_x86_64.manylinux2014_x86_64.manylinux_2_28_x86_64.whl (12.6 MB)
[3980]   Using cached pex-2.24.1-py2.py3-none-any.whl (3.6 MB)
[3980]   Using cached mypy_extensions-1.0.0-py3-none-any.whl (4.7 kB)
[3980]   Using cached typing_extensions-4.12.2-py3-none-any.whl (37 kB)
[3980]   Installing collected packages: typing-extensions, pex, mypy-extensions, mypy
[3980]   Successfully installed mypy-1.13.0 mypy-extensions-1.0.0 pex-2.24.1 typing-extensions-4.12.2
[3980]   test_mean (test.TestScript.test_mean) ... Using BarTestUtils.bar_assert_equals
[3980]   ok
[3980]   ----------------------------------------------------------------------
[3980]   Ran 1 test in 0.000s
[3980]   OK
[3980]   expectedLine: String = ...test_mean (test.TestScript...)...ok...
[3980]   expectedLine: String = ...test_mean (test.TestScript...)...ok...
[3980]   expectedLine: String = ...test_mean (test.TestScript...)...ok...
[3980]   expectedLine: String = ...test_mean (test.TestScript...)...ok...
[3980]   expectedLine: String = ...test_mean (test.TestScript...)...ok...
[3980]   expectedLine: String = ...test_mean (test.TestScript...)...ok...
[3980]   expectedLine: String = ...test_mean (test.TestScript...)...ok...
[3980]   expectedLine: String = ...test_mean (test.TestScript...)...ok...
[3980]   expectedLine: String = ...test_mean (test.TestScript...)...ok...
[3980]   expectedLine: String = ...test_mean (test.TestScript...)...ok...
[3980]   expectedLine: String = ...test_mean (test.TestScript...)...ok...
[3980]   expectedLine: String = ...test_mean (test.TestScript...)...ok...
[3980]   expectedLine: String = ...test_mean (test.TestScript...)...ok...
[3980]   expectedLine: String = ...test_mean (test.TestScript...)...ok...
[3980]   expectedLine: String = ...test_mean (test.TestScript...)...ok...
[3980]   expectedLine: String = ...test_mean (test.TestScript...)...ok...
[3980]   expectedLine: String = ...test_mean (test.TestScript...)...ok...
[3980]   expectedLine: String = ...test_mean (test.TestScript...)...ok...
[3980]   expectedLine: String = ...test_mean (test.TestScript...)...ok...
[3980]     utest.asserts.Asserts$.assertImpl(Asserts.scala:30)
[3980]     mill.testkit.ExampleTester.$anonfun$validateEval$7(ExampleTester.scala:171)
[3980]     mill.testkit.ExampleTester.$anonfun$validateEval$7$adapted(ExampleTester.scala:170)
[3980]     scala.collection.IterableOnceOps.foreach(IterableOnce.scala:619)
[3980]     scala.collection.IterableOnceOps.foreach$(IterableOnce.scala:617)
[3980]     scala.collection.AbstractIterator.foreach(Iterator.scala:1[303](https://github.com/com-lihaoyi/mill/actions/runs/12596075634/job/35106699515?pr=4166#step:11:304))
[3980]     mill.testkit.ExampleTester.validateEval(ExampleTester.scala:170)
[3980]     mill.testkit.ExampleTester.processCommand(ExampleTester.scala:134)
[3980]     mill.testkit.ExampleTester.processCommandBlock(ExampleTester.scala:95)
[3980]     mill.testkit.ExampleTester.$anonfun$run$2(ExampleTester.scala:194)
[3980]     mill.testkit.ExampleTester.$anonfun$run$2$adapted(ExampleTester.scala:194)
[3980]     scala.collection.ArrayOps$.foreach$extension(ArrayOps.scala:1323)
[3980]     mill.testkit.ExampleTester.run(ExampleTester.scala:194)
[3980]     mill.testkit.ExampleTester$.run(ExampleTester.scala:61)
[3980]     mill.testkit.UtestExampleTestSuite$.$anonfun$tests$3(UtestExampleTestSuite.scala:19)
[3980]     scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.scala:18)
[3980]     mill.api.Retry.$anonfun$apply$1(Retry.scala:32)
[3980]     mill.api.Retry.$anonfun$apply$1$adapted(Retry.scala:32)
[3980]     mill.api.Retry.$anonfun$indexed$2(Retry.scala:42)
[3980]     scala.util.Try$.apply(Try.scala:217)
[3980]     mill.api.Retry.$anonfun$indexed$1(Retry.scala:42)
[3980]     java.lang.Thread.run(Thread.java:840)
[3980] Tests: 1, Passed: 0, Failed: 1
[3980] [3980] example.pythonlib.testing[2-test-deps].local.test failed

jodersky

Thanks for your patience @himanshumahajan138 I finally got to reviewing your PR.

It think it's looking good, but there are still a few changes to be made before we can merge it

docs/modules/ROOT/pages/pythonlib/testing.adoc

example/pythonlib/testing/1-test-suite/build.mill

example/pythonlib/testing/1-test-suite/foo/test/src/test_foo.py

example/pythonlib/testing/1-test-suite/build.mill

example/pythonlib/testing/2-test-deps/build.mill

example/pythonlib/testing/2-test-deps/bar/test/src/test.py

jodersky · 2025-01-04T14:00:59Z

example/pythonlib/testing/2-test-deps/build.mill

+
+  object test extends PythonTests with TestModule.Unittest {
+    def moduleDeps = super.moduleDeps ++ Seq(bar.test)
+


it would be nice to show pythonDeps used here too, since it's mentioned in the text above

yup why not !

i will use the inbuilt libs which we are also using in the backend just for demo purposes

one thing i want to mention is that if i added some library in the foo object then it will be available for test also(you know this)

so why we should add some libs demo in test ?

Altough i have added still for demo Purpose

I think it would be better to add a python dependency to the test and use that.

so why we should add some libs demo in test ?

The reason is to show how a user can use a library in tests (for example a helper function), but not depend on it in the main module

Once that is done, you have green light to merge from me. However I'd like @lihaoyi to sign off first due to the failing CI test which appears to be unrelated, but I don't want to take any chances

sir let choose one thing and add something you too want...

Use some library in the test which we will use only in test object and show that example on top of this

Add some test library in the test (maybe PyTest) and use that to perform test

Add your requirement in these with instruction please

Moreover, i think that this failing testcase is Flaky and will get passed on multiple runs (on its own)

example/pythonlib/testing/2-test-deps/build.mill

himanshumahajan138 · 2025-01-04T14:20:58Z

@jodersky its great to see you back ✨

Thanks for Reviewing!

let me Update the Code and then Finalize this and move ahead to further support 🤞

himanshumahajan138 · 2025-01-04T16:57:59Z

@jodersky Sir All Done ✨

Let's get up in Contribution Leaderboard 🤞

jodersky

Almost there! If you can show pythonDeps being used in tests then I think this is good to go.

Not sure what's up with the failing android test. Let's retry once more

example/pythonlib/testing/2-test-deps/build.mill

himanshumahajan138 · 2025-01-04T19:40:39Z

Not sure what's up with the failing android test. Let's retry once more

Actually Mill's CI have some type of personal issue(grudge) with me i.e why it always fails irrelevantly in my PR's 😂

himanshumahajan138 · 2025-01-05T11:04:26Z

@jodersky i have added a beautiful example for 2-test-deps for including the concept of using pythonDeps

Give a Green Pass for @lihaoyi to merge this ✨ (If Satisfied)

himanshumahajan138 · 2025-01-06T10:12:18Z

@jodersky Sir, please see if i addressed your concern...

example/pythonlib/testing/1-test-suite/build.mill

example/pythonlib/testing/1-test-suite/bar/test/src/test_bar.py

himanshumahajan138 · 2025-01-06T14:45:50Z

@lihaoyi Updated Based on Your Reviews!

himanshumahajan138 · 2025-01-07T18:35:34Z

Are we Merging ???

himanshumahajan138 · 2025-01-08T05:16:10Z

@lihaoyi & @jodersky Thanks Sir for Your Support and Guide ✨

himanshumahajan138 and others added 2 commits December 19, 2024 23:58

first Testing Phase

1509030

Merge branch 'main' into issue-3928-testing

fbf2696

himanshumahajan138 and others added 4 commits December 24, 2024 19:21

Merge branch 'main' into issue-3928-testing

59a0f2c

Final Update

f717a41

Merge branch 'com-lihaoyi:main' into issue-3928-testing

18d0a09

Merge branch 'issue-3928-testing' of https://www.github.com/himanshum…

c701d0a

…ahajan138/mill into issue-3928-testing

himanshumahajan138 added 2 commits December 26, 2024 18:32

Merge branch 'main' into issue-3928-testing

6848ab3

Merge branch 'main' into issue-3928-testing

eecf882

himanshumahajan138 added 4 commits December 29, 2024 12:47

Merge branch 'main' into issue-3928-testing

281b084

Merge branch 'main' into issue-3928-testing

0c2776f

Merge branch 'main' into issue-3928-testing

d16e4a9

Merge branch 'main' into issue-3928-testing

8c26d7e

himanshumahajan138 added 2 commits January 2, 2025 15:03

Merge branch 'main' into issue-3928-testing

69ec4b6

Merge branch 'main' into issue-3928-testing

bedac84

jodersky reviewed Jan 4, 2025

View reviewed changes

Final Update

514472a

jodersky approved these changes Jan 4, 2025

View reviewed changes

example/pythonlib/testing/2-test-deps/build.mill Outdated Show resolved Hide resolved

himanshumahajan138 and others added 2 commits January 5, 2025 16:06

Merge branch 'main' into issue-3928-testing

aa39555

Beautiful Example Addition

d2cac28

himanshumahajan138 and others added 3 commits January 6, 2025 13:44

Final

1ac3377

Merge branch 'main' into issue-3928-testing

c8c9464

Merge branch 'main' into issue-3928-testing

ae2701e

Merge branch 'main' into issue-3928-testing

9099187

lihaoyi reviewed Jan 6, 2025

View reviewed changes

himanshumahajan138 and others added 2 commits January 6, 2025 20:03

Merge branch 'main' into issue-3928-testing

8b32312

Li Haoyi Reviews Updation

2f19243

Merge branch 'main' into issue-3928-testing

a1bf122

lihaoyi merged commit b60ad32 into com-lihaoyi:main Jan 7, 2025
25 of 26 checks passed

lefou added this to the 0.12.6 milestone Jan 8, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Part of #3928 [Testing Examples] Add First Class Python Support #4166

Part of #3928 [Testing Examples] Add First Class Python Support #4166

himanshumahajan138 commented Dec 19, 2024 •

edited

Loading

lihaoyi commented Dec 23, 2024

himanshumahajan138 commented Dec 24, 2024

himanshumahajan138 commented Dec 27, 2024

jodersky commented Dec 27, 2024 via email

himanshumahajan138 commented Dec 27, 2024 •

edited

Loading

jodersky commented Jan 2, 2025

himanshumahajan138 commented Jan 3, 2025 •

edited

Loading

jodersky left a comment

jodersky Jan 4, 2025

himanshumahajan138 Jan 4, 2025

himanshumahajan138 Jan 4, 2025

himanshumahajan138 Jan 5, 2025

jodersky Jan 5, 2025 •

edited

Loading

himanshumahajan138 Jan 5, 2025

himanshumahajan138 commented Jan 4, 2025

himanshumahajan138 commented Jan 4, 2025

jodersky left a comment

himanshumahajan138 commented Jan 4, 2025 •

edited

Loading

himanshumahajan138 commented Jan 5, 2025

himanshumahajan138 commented Jan 6, 2025

himanshumahajan138 commented Jan 6, 2025

himanshumahajan138 commented Jan 7, 2025

himanshumahajan138 commented Jan 8, 2025


		object test extends PythonTests with TestModule.Unittest {
		def moduleDeps = super.moduleDeps ++ Seq(bar.test)

Part of #3928 [Testing Examples] Add First Class Python Support #4166

Part of #3928 [Testing Examples] Add First Class Python Support #4166

Conversation

himanshumahajan138 commented Dec 19, 2024 • edited Loading

Pull Request

Description

Related Issues

Checklist

Status

lihaoyi commented Dec 23, 2024

himanshumahajan138 commented Dec 24, 2024

himanshumahajan138 commented Dec 27, 2024

jodersky commented Dec 27, 2024 via email

himanshumahajan138 commented Dec 27, 2024 • edited Loading

jodersky commented Jan 2, 2025

himanshumahajan138 commented Jan 3, 2025 • edited Loading

jodersky left a comment

Choose a reason for hiding this comment

jodersky Jan 4, 2025

Choose a reason for hiding this comment

himanshumahajan138 Jan 4, 2025

Choose a reason for hiding this comment

himanshumahajan138 Jan 4, 2025

Choose a reason for hiding this comment

himanshumahajan138 Jan 5, 2025

Choose a reason for hiding this comment

jodersky Jan 5, 2025 • edited Loading

Choose a reason for hiding this comment

himanshumahajan138 Jan 5, 2025

Choose a reason for hiding this comment

himanshumahajan138 commented Jan 4, 2025

himanshumahajan138 commented Jan 4, 2025

jodersky left a comment

Choose a reason for hiding this comment

himanshumahajan138 commented Jan 4, 2025 • edited Loading

himanshumahajan138 commented Jan 5, 2025

himanshumahajan138 commented Jan 6, 2025

himanshumahajan138 commented Jan 6, 2025

himanshumahajan138 commented Jan 7, 2025

himanshumahajan138 commented Jan 8, 2025

himanshumahajan138 commented Dec 19, 2024 •

edited

Loading

himanshumahajan138 commented Dec 27, 2024 •

edited

Loading

himanshumahajan138 commented Jan 3, 2025 •

edited

Loading

jodersky Jan 5, 2025 •

edited

Loading

himanshumahajan138 commented Jan 4, 2025 •

edited

Loading