Build PyQt5 wheel in parallel #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dockerfile.agnos
Outdated
| @@ -29,6 +29,12 @@ COPY ./userspace/openpilot_dependencies.sh /tmp/agnos/ | |||
| RUN /tmp/agnos/openpilot_dependencies.sh | |||
|
|
|||
| # Individual compiling images | |||
| FROM agnos-compiler AS agnos-compiler-pyqt5 | |||
| COPY ./userspace/openpilot_python_dependencies.sh /tmp/agnos/ | |||
| RUN /tmp/agnos/openpilot_python_dependencies.sh | |||
There was a problem hiding this comment.
why is this done twice?
There was a problem hiding this comment.
can we copy the rest of the dependencies out of here too?
|
@robin-reckmann want to finish this one up? Looks ready to go aside from the double python deps. |
robin-reckmann
force-pushed
the
build-pyqt5-wheel
branch
from
3e555bf to
d7e4f8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build PyQt5 wheel in parallel to other compilation steps and install from wheel later.
This reduces the overall Docker build time and makes better use of the Docker build cache.
Tests: Builds and runs on C3. Openpilot compiles, GUI works. (Not tested on-road)