Honda: missing float (#1661)

* missing float * more
commaai · Jan 23, 2025 · 00bb29c · 00bb29c
1 parent 7ceed32
commit 00bb29c
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/opendbc/car/honda/carcontroller.py b/opendbc/car/honda/carcontroller.py
@@ -181,7 +181,7 @@ def update(self, CC, CS, now_nanos):
                      np.clip(CS.out.vEgo - 3.0, 0.0, 100.0),
                      np.clip(CS.out.vEgo + 0.0, 0.0, 100.0),
                      np.clip(CS.out.vEgo + 5.0, 0.0, 100.0)]
-      pcm_speed = np.interp(gas - brake, pcm_speed_BP, pcm_speed_V)
+      pcm_speed = float(np.interp(gas - brake, pcm_speed_BP, pcm_speed_V))
       pcm_accel = int(1.0 * self.params.NIDEC_GAS_MAX)
     else:
       pcm_speed_V = [0.0,

diff --git a/opendbc/car/honda/carstate.py b/opendbc/car/honda/carstate.py
@@ -174,8 +174,7 @@ def update(self, can_parsers) -> structs.CarState:
     v_wheel = (ret.wheelSpeeds.fl + ret.wheelSpeeds.fr + ret.wheelSpeeds.rl + ret.wheelSpeeds.rr) / 4.0
 
     # blend in transmission speed at low speed, since it has more low speed accuracy
-    v_weight = np.interp(v_wheel, v_weight_bp, v_weight_v)
-    v_weight = float(v_weight)
+    v_weight = float(np.interp(v_wheel, v_weight_bp, v_weight_v))
     ret.vEgoRaw = (1. - v_weight) * cp.vl["ENGINE_DATA"]["XMISSION_SPEED"] * CV.KPH_TO_MS * self.CP.wheelSpeedFactor + v_weight * v_wheel
     ret.vEgo, ret.aEgo = self.update_speed_kf(ret.vEgoRaw)
 

diff --git a/opendbc/car/toyota/carcontroller.py b/opendbc/car/toyota/carcontroller.py
@@ -210,7 +210,7 @@ def update(self, CC, CS, now_nanos):
 
         # GVC does not overshoot ego acceleration when starting from stop, but still has a similar delay
         if not self.CP.flags & ToyotaFlags.SECOC.value:
-          a_ego_blended = np.interp(CS.out.vEgo, [1.0, 2.0], [CS.gvc, CS.out.aEgo])
+          a_ego_blended = float(np.interp(CS.out.vEgo, [1.0, 2.0], [CS.gvc, CS.out.aEgo]))
         else:
           a_ego_blended = CS.out.aEgo
 
@@ -287,7 +287,7 @@ def update(self, CC, CS, now_nanos):
     new_actuators = actuators.as_builder()
     new_actuators.steer = apply_steer / self.params.STEER_MAX
     new_actuators.steerOutputCan = apply_steer
-    new_actuators.steeringAngleDeg = float(self.last_angle)
+    new_actuators.steeringAngleDeg = self.last_angle
     new_actuators.accel = self.accel
 
     self.frame += 1