Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

car.capnp: LongitudinalPIDTuning kd derivative term #1615

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ntegan1
Copy link

@ntegan1 ntegan1 commented Jan 8, 2025

Allow for cars that utilize the derivative term in longitudinal PID tuning
to log the derivative term along with the rest.

@github-actions github-actions bot added the car related to opendbc/car/ label Jan 8, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to opendbc! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • include a route or your device' dongle ID if relevant

@ntegan1
Copy link
Author

ntegan1 commented Jan 9, 2025

Trying to think of how to log Toyota longitudinal tuning.

cereal/log.capnp ControlsState-> {upAccelCmd, uiAccelCmd, ufAccelCmd} no longer help with longitudinal tuning as only the default tune of 1.0 kf term is used, and custom carcontroller pid turns the model's desired accel into pcm accel command.

We aren't logging this car-specific tune.

Could we add logging to CarParams for a secondary kp, kd, ki, kf as well as logging for secondary ui, up, uf, ud accel Cmd?

@ntegan1 ntegan1 marked this pull request as draft January 9, 2025 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
car related to opendbc/car/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant