-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cache get_torque_params #32560
cache get_torque_params #32560
Conversation
Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:
|
nice! speeds up the test with 8 procs from ~37 to ~30s for me! I wonder why the unit tests take 2x longer in CI though. I re-ran it |
Can you see why the unit tests take much longer now? |
This comment was marked as outdated.
This comment was marked as outdated.
@sshane |
#32586 is a further optimization. @sshane: update: Therefore, commaai/opendbc#942 does not enhance the performance of test_car_interface. |
* cache get_torque_params * switch to cache * Update selfdrive/car/interfaces.py --------- Co-authored-by: Shane Smiskol <[email protected]> old-commit-hash: 8f4b00c
lots of io in get_torque_params (and it's is called twice in get_params for a lot of cars)
could also pass it through
re: #32536
I'll look for further ways to speed up