Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sonic streams #24

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Fix sonic streams #24

merged 2 commits into from
Mar 13, 2024

Commits on Mar 10, 2024

  1. chore: bump dev dependencies

    @commenthol
    commenthol committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    2f6d723 View commit details
    Browse the repository at this point in the history

  2. fix(#23): reuse same sonic streams 

    On nodejs each Log instance using sonic streams adds event listeners to
process.exit which then displays a MaxListenersExceededWarning.

This PR adds a global cache where same streams with same options are being
reused. If a lot of variants for streams or options are used, the
MaxListenersExceededWarning may still show up.
    @commenthol
    commenthol committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    451e6c0 View commit details
    Browse the repository at this point in the history