Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace cookie usage with session storage for app cross-linking #856

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

gciotola
Copy link
Contributor

What I did

I moved the persistency of the "go back" item in session storage.
This will allow to:

  • keep separated history between different tabs
  • do not pollute cookies with unwanted data

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests).
  • Make sure to add/update documentation regarding your changes.
  • You are NOT deprecating/removing a feature.

@gciotola gciotola self-assigned this Dec 17, 2024
@gciotola gciotola added the enhancement New feature or request label Dec 17, 2024
Copy link

netlify bot commented Dec 17, 2024

Deploy Preview for commercelayer-app-elements ready!

Name Link
🔨 Latest commit 492e058
🔍 Latest deploy log https://app.netlify.com/sites/commercelayer-app-elements/deploys/67613af4ec227a00089c0b2c
😎 Deploy Preview https://deploy-preview-856--commercelayer-app-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@gciotola gciotola merged commit f622295 into main Dec 17, 2024
7 checks passed
@gciotola gciotola deleted the use-navigation branch December 17, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants