This repository has been archived by the owner on Sep 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gciotola
previously approved these changes
Jan 26, 2024
marcomontalbano
force-pushed
the
enhance-rule-builder
branch
from
January 29, 2024 09:54
10735cb
to
20b5768
Compare
gciotola
approved these changes
Jan 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I improved the Rule Builder UX:
Cart total
andCart subtotal
should be visible only when there's ONLY ONE currency in scope.market
rule is set, thecurrency
parameter should be filtered based on selected markets.currency
rule is set (one or more), themarket
parameter should be filtered by all market with that selected list of currencies.improve-rule-builder.mp4
Checklist