Skip to content
This repository has been archived by the owner on Sep 24, 2024. It is now read-only.

Improve rule builder #4

Merged
merged 20 commits into from
Jan 30, 2024
Merged

Improve rule builder #4

merged 20 commits into from
Jan 30, 2024

Conversation

marcomontalbano
Copy link
Member

@marcomontalbano marcomontalbano commented Jan 22, 2024

What I did

I improved the Rule Builder UX:

  • User should not be able to select an already set rule (hide already set rules).
  • Cart total and Cart subtotal should be visible only when there's ONLY ONE currency in scope.
  • When market rule is set, the currency parameter should be filtered based on selected markets.
  • When currency rule is set (one or more), the market parameter should be filtered by all market with that selected list of currencies.
  • The list of currencies should be calculated base on the promotion currency, promotion market and filters within the custom promotion rules
  • Disable non applicable rules
improve-rule-builder.mp4

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests).
  • Make sure to add/update documentation regarding your changes.
  • You are NOT deprecating/removing a feature.

@marcomontalbano marcomontalbano changed the title Enhance rule builder Improve rule builder Jan 26, 2024
@marcomontalbano marcomontalbano marked this pull request as ready for review January 26, 2024 15:02
@marcomontalbano marcomontalbano self-assigned this Jan 26, 2024
@marcomontalbano marcomontalbano added the enhancement New feature or request label Jan 26, 2024
gciotola
gciotola previously approved these changes Jan 26, 2024
@marcomontalbano marcomontalbano merged commit 4f67fcd into main Jan 30, 2024
4 checks passed
@marcomontalbano marcomontalbano deleted the enhance-rule-builder branch January 30, 2024 16:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants