-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add feedback feature to self-learning pages #2093
Conversation
🦋 Changeset detectedLatest commit: 0f5daae The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Preview URLs:
|
@zbalek Would you mind having a look to what implemented so far: Let me know if you have any observations or you'd like to change anything. |
I also did some test throttling the network to see how bad is the UX on the first load.
The good thing is that the user gets an instantaneously feedback (the thumbs icon changes color) and it doesn't feel too bad to wait a couple of seconds for a feeback popup, I've seen some sites delaying the feedback modal on purpose. |
Looks great @gabriele-ct! The behavior is as expected. Re the loading speed: Thanks for checking this! Imho, this is also really good. Re mobile: I cross-checked the requirements and we actually haven't defined the situation for mobile (which is when users may be the most likely to access the pages using 4G). And so I was wondering if it is possible to only enable the feedback feature only up to a tablet size screen - at least for the MVP. (I tried to test the mobile version (SE) just now and it is breaking a bit.) |
@zbalek could you please have another look? I addressed the points you suggested. Thank you |
All good now - thank you! |
@FFawzy I haven't been able to reproduce the non loading survey issue, would you mind double check if we're good to merge this? |
@gabriele-ct .. Unfortunately I can still reproduce it. userguiding-bug.mov |
Thank you for finding out the repro path. It helped a lot. I also added google tag calls. It should be ready for a final review 🙇 |
Pinging @nkuehn as he is defacto the Self Learning stakeholder for this feature. Thank you |
Oh, thanks! I like it a lot, very nice direct user experience. I looked at the debug / log a bit, too and it seems we're really only loading userguiding when needed. Did you check with data protection team whether we they have to do something that the cookie consent banner is maybe re-shown again (or, at least that they have documented that we have userguiding on the docs site now)? |
Properly specified ✅
I'll send them an email to check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Just a few small comments
packages/gatsby-theme-docs/src/modules/ai-assistant/components/chat-messages.jsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@FFawzy shall we consider this PR "blocked" until we hear back from data protection team? |
@gabriele-ct we are good to go 🙌 they only needed me to file a report with some details and I did it so we are good to go. |
… page (#2085) Description of changes Align layout header and layout page content for release notes util for shared layout for header and page content refactor grid layouts Shared const IDs in layout components extracted config and logic Link to original ticket closes #2068 * feat: Shared Page Content layout util * chore: use global grid ids in layouts * chore: add changeset * fix: xl column2 bug * chore: code improvements * fix: header row height * fix: column2 tablet * chore: update comment * fix: column2 fixed body
Description of changes
Adding feedback functionality connected to userguiding to self-learning pages
Link to original ticket
https://github.com/commercetools/commercetools-docs/issues/4637
Link to change (deep-link for reviewing the change)
https://docskit-ga-userguiding-script-injection.commercetools.vercel.app/self-learning-smoke-test/course-1/2-quiz
Screenshot of changes (if applicable)
DoD guidelines